Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix!: Upgrade executor in separate transaction in genesis block #4757

Merged
merged 2 commits into from
Jun 25, 2024
Merged

fix!: Upgrade executor in separate transaction in genesis block #4757

merged 2 commits into from
Jun 25, 2024

Conversation

dima74
Copy link
Contributor

@dima74 dima74 commented Jun 21, 2024

Description

GenesisBlock now have two transactions, first with single Upgrade instruction to set executor, and second with all other instructions. If there are no other instructions, second transaction will be omitted.

Linked issue

Closes #4743

Benefits

Checklist

  • I've read CONTRIBUTING.md
  • I've used the standard signed-off commit format (or will squash just before merging)
  • All applicable CI checks pass (or I promised to make them pass later)
  • (optional) I've written unit tests for the code changes
  • I replied to all comments after code review, marking all implemented changes with thumbs up

@dima74 dima74 self-assigned this Jun 21, 2024
mversic
mversic reviewed Jun 21, 2024
View reviewed changes
@dima74 dima74 requested a review from mversic June 21, 2024 16:43
@dima74 dima74 force-pushed the diralik/validate-genesis-instructions-by-executor branch from 446f671 to 167ed07 Compare June 24, 2024 08:02
@mversic mversic force-pushed the diralik/validate-genesis-instructions-by-executor branch from 167ed07 to d856b7d Compare June 24, 2024 08:57
0x009922
0x009922 approved these changes Jun 24, 2024
View reviewed changes
Copy link
Contributor

@0x009922 0x009922 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Anyway, clean work.

@mversic mversic force-pushed the diralik/validate-genesis-instructions-by-executor branch from d856b7d to 0cabc43 Compare June 25, 2024 08:07
@mversic mversic enabled auto-merge (squash) June 25, 2024 08:08
@mversic mversic disabled auto-merge June 25, 2024 08:08
@mversic mversic enabled auto-merge (squash) June 25, 2024 08:09
@mversic mversic disabled auto-merge June 25, 2024 08:09
@mversic mversic enabled auto-merge (squash) June 25, 2024 08:09
@mversic mversic mentioned this pull request Jun 25, 2024
Open
@mversic mversic merged commit 6ae7b6c into hyperledger-iroha:main Jun 25, 2024
10 of 11 checks passed
hollermay pushed a commit to hollermay/iroha that referenced this pull request Jun 28, 2024
@dima74 @hollermay
fix!: Upgrade executor in separate transaction in genesis block (hype…
9eaf2ee 
…rledger-iroha#4757)

Signed-off-by: Dmitry Murzin <[email protected]>
@dima74 dima74 deleted the diralik/validate-genesis-instructions-by-executor branch July 3, 2024 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mversic mversic mversic approved these changes

@0x009922 0x009922 0x009922 approved these changes

@s8sato s8sato Awaiting requested review from s8sato s8sato is a code owner

@SamHSmith SamHSmith Awaiting requested review from SamHSmith

@outoftardis outoftardis Awaiting requested review from outoftardis outoftardis is a code owner

@Erigara Erigara Awaiting requested review from Erigara

@DCNick3 DCNick3 Awaiting requested review from DCNick3 DCNick3 is a code owner

Assignees

@dima74 dima74

@0x009922 0x009922

@mversic mversic

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Validate genesis instructions
3 participants
@dima74 @0x009922 @mversic