Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(md): fix typos in CONTRIBUTING, iroha_2_whitepaper, hot-reload #4768

Merged
merged 1 commit into from
Jun 26, 2024

Conversation

omahs
Copy link
Contributor

@omahs omahs commented Jun 25, 2024

docs(md): fix typos in CONTRIBUTING, iroha_2_whitepaper, hot-reload

Copy link
Contributor

@nxsaken nxsaken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thanks for your contribution!

Please fix your commit messages to follow Conventional Commits, and be more specific about where you fixed the typos.

@omahs omahs changed the title docs: fix typos chore: fix typos in CONTRIBUTING.md, iroha_2_whitepaper.md and hot-reload.md Jun 25, 2024
@nxsaken
Copy link
Contributor

nxsaken commented Jun 26, 2024

The PR title should be the same as the commit message if you only have one commit. docs: fits the commit type better in this case, not chore

@omahs omahs changed the title chore: fix typos in CONTRIBUTING.md, iroha_2_whitepaper.md and hot-reload.md docs: fix typos in CONTRIBUTING.md, iroha_2_whitepaper.md and hot-reload.md Jun 26, 2024
@omahs
Copy link
Contributor Author

omahs commented Jun 26, 2024

@nxsaken Should I edit the commit message to "docs: fix typos in CONTRIBUTING.md, iroha_2_whitepaper.md and hot-reload.md"? It seems long but I can.

@nxsaken
Copy link
Contributor

nxsaken commented Jun 26, 2024

You can change both to docs(md): fix typos in CONTRIBUTING, iroha_2_whitepaper, hot-reload

@omahs omahs changed the title docs: fix typos in CONTRIBUTING.md, iroha_2_whitepaper.md and hot-reload.md docs(md): fix typos in CONTRIBUTING, iroha_2_whitepaper, hot-reload Jun 26, 2024
@omahs
Copy link
Contributor Author

omahs commented Jun 26, 2024

@nxsaken Thanks for the review, just updated!

@nxsaken nxsaken merged commit 1d365e9 into hyperledger-iroha:main Jun 26, 2024
3 checks passed
hollermay pushed a commit to hollermay/iroha that referenced this pull request Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants