-
Notifications
You must be signed in to change notification settings - Fork 277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: reimplement multisignature transactions #4788
Conversation
client/tests/integration/smartcontracts/multisig_register/src/lib.rs
Outdated
Show resolved
Hide resolved
c31cbc1
to
b2b0601
Compare
client/tests/integration/smartcontracts/multisig_register/Cargo.toml
Outdated
Show resolved
Hide resolved
d86071b
to
2148c02
Compare
client/tests/integration/smartcontracts/executor_custom_data_model/src/multisig.rs
Outdated
Show resolved
Hide resolved
3c6f11b
to
1f2407c
Compare
client/tests/integration/smartcontracts/mint_rose_trigger_args/src/lib.rs
Show resolved
Hide resolved
client/tests/integration/smartcontracts/executor_custom_data_model/src/multisig.rs
Show resolved
Hide resolved
great piece of work. It would be interesting to explore whether we can make a custom instruction for |
i think it should be possible, in this case we would move logic of multisig register trigger into the executor which would be triggered on custom instruction |
Signed-off-by: Shanin Roman <[email protected]>
Signed-off-by: Shanin Roman <[email protected]>
Signed-off-by: Shanin Roman <[email protected]>
Signed-off-by: Shanin Roman <[email protected]>
Signed-off-by: Shanin Roman <[email protected]>
Signed-off-by: Shanin Roman <[email protected]>
Signed-off-by: Shanin Roman <[email protected]>
Description
This PR provide an example how multisignature transactions could be implemented using iroha triggers.
In this PR i've tried to make as small invasive changes into the core as possible.
How this work?
There is 2 triggers (thanks @s8sato for inspiration in account activation feature):
multisig_register
- responsible for registering new multisig user and triggermultisig
multisig
- responsible for executing instructions on behalf of multisig user when enough votes are collectedAssumptions:
multisig_register
should be registered either as part of genesis or by domain owner to have enough permissions for it's actionsLinked issue
Closes #4373
Benefits
Get back multisig functionality without too much changes on iroha side.
Downsides
Executing multisig instructions through tirgger probably slower that backed in solution.