refactor!: split executor data model #4791
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mversic
requested review from
s8sato,
SamHSmith,
outoftardis,
Erigara,
0x009922,
DCNick3 and
dima74
as code owners
mversic
force-pushed
the
permissions_data_model
branch
from
f168373 to
e461b64
Compare
nxsaken
reviewed
Jul 1, 2024
mversic
force-pushed
the
permissions_data_model
branch
3 times, most recently
from
0036e62 to
a27e361
Compare
|
Schema and formatting checks failed |
mversic
force-pushed
the
permissions_data_model
branch
from
a27e361 to
3b1885a
Compare
mversic
force-pushed
the
permissions_data_model
branch
4 times, most recently
from
8e4af7f to
c2e0461
Compare
mversic
force-pushed
the
permissions_data_model
branch
from
c2e0461 to
a56aa33
Compare
mversic
commented
Jul 1, 2024
client/tests/integration/smartcontracts/executor_with_custom_permission/src/lib.rs
Show resolved
Hide resolved
mversic
force-pushed
the
permissions_data_model
branch
5 times, most recently
from
d423b54 to
cd793e3
Compare
mversic
force-pushed
the
permissions_data_model
branch
from
cd793e3 to
ce0b715
Compare
nxsaken
previously approved these changes
Jul 1, 2024
Erigara
reviewed
Jul 1, 2024
client/tests/integration/smartcontracts/executor_remove_permission/src/lib.rs
Show resolved
Hide resolved
mversic
force-pushed
the
permissions_data_model
branch
3 times, most recently
from
bade3f1 to
4c870e1
Compare
nxsaken
previously approved these changes
Jul 1, 2024
mversic
force-pushed
the
permissions_data_model
branch
from
4c870e1 to
2fe98c3
Compare
mversic
force-pushed
the
permissions_data_model
branch
from
2fe98c3 to
b880f41
Compare
Signed-off-by: Marin Veršić <[email protected]>
mversic
force-pushed
the
permissions_data_model
branch
from
b880f41 to
7499e0d
Compare
Erigara
approved these changes
Jul 1, 2024
nxsaken
approved these changes
Jul 1, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
derivecrates from workspace dependenciesexecutorintodata_modelandcorecratesMigrationResult-> migration should always succeed, the error is unrecoverableLinked issue
#4552
Benefits
json!againChecklist
CONTRIBUTING.md