Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Keep voting block if possible #4828

Merged
merged 2 commits into from
Jul 12, 2024

Conversation

dima74
Copy link
Contributor

@dima74 dima74 commented Jul 9, 2024

Description

Implements idea from #4518 (comment):

Maybe we can be smarter about when to reject incoming block? Like checking signatures, height, hashes this checks doesn’t need ability to modify state.

This is relatively small change which I think will keep voting block in most cases (however not in all).


Alternative approach might be to change our state block to accumulate changes localy and take write lock just before applying changes. However it will require large refactoring and might affect performance.

Linked issue

Closes #4643

Benefits

Checklist

  • I've read CONTRIBUTING.md
  • I've used the standard signed-off commit format (or will squash just before merging)
  • All applicable CI checks pass (or I promised to make them pass later)
  • (optional) I've written unit tests for the code changes
  • I replied to all comments after code review, marking all implemented changes with thumbs up

@dima74 dima74 self-assigned this Jul 9, 2024
@Erigara Erigara self-assigned this Jul 10, 2024
@mversic mversic self-assigned this Jul 10, 2024
@dima74 dima74 force-pushed the diralik/keep-voting-block branch from 1f542b7 to b8e6512 Compare July 11, 2024 09:52
dima74 added 2 commits July 12, 2024 09:46
Signed-off-by: Dmitry Murzin <[email protected]>
@mversic mversic force-pushed the diralik/keep-voting-block branch from b8e6512 to 5e735c6 Compare July 12, 2024 07:46
@mversic mversic merged commit 137d766 into hyperledger-iroha:main Jul 12, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Keep voting blocks
3 participants