Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: remove public key from ed25519 private key #4856

Merged
merged 1 commit into from
Jul 17, 2024

Conversation

Erigara
Copy link
Contributor

@Erigara Erigara commented Jul 17, 2024

Description

Before ed25519 private key was represented as concatenation of private key and private key.
After the changes introduced in this PR it is just private key.

Linked issue

Closes #4838

Benefits

Private keys are more compact and doesn't contain unnecessary information.

Downsides

Iroha environments have to be updated.

For reviewers

All actual changes are in:

@Erigara
Copy link
Contributor Author

Erigara commented Jul 17, 2024

@BAStos525 this change require changing private keys in the following way:

  1. replace private key prefix 802640 -> 802620
  2. remove last 64 characters from private key (which correspond to public key)

@mversic mversic merged commit d971c1a into hyperledger-iroha:main Jul 17, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove public key from private key
3 participants