-
Notifications
You must be signed in to change notification settings - Fork 277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Add limits to LiveQueryStore to prevent high memory usage #4893
Merged
mversic
merged 3 commits into
hyperledger-iroha:main
from
dima74:diralik/live-query-store-limit
Jul 26, 2024
Merged
fix: Add limits to LiveQueryStore to prevent high memory usage #4893
mversic
merged 3 commits into
hyperledger-iroha:main
from
dima74:diralik/live-query-store-limit
Jul 26, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mversic
reviewed
Jul 26, 2024
83fdfc5
to
d2620ed
Compare
mversic
previously approved these changes
Jul 26, 2024
mversic
reviewed
Jul 26, 2024
@dima74 |
Signed-off-by: Dmitry Murzin <[email protected]>
Signed-off-by: Dmitry Murzin <[email protected]>
Signed-off-by: Dmitry Murzin <[email protected]>
84381f8
to
d44b748
Compare
mversic
approved these changes
Jul 26, 2024
nxsaken
approved these changes
Jul 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
api-changes
Changes in the API for client libraries
config-changes
Changes in configuration and start up of the Iroha
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added two new config parameters which limits number of live queries (global and per-user). Default value for both is 128. This is needed to prevent high memory usage in cases when client sends a lot of queries with large output, but do not fully consume those queries (that is obtain only first batch and doesn't send requests for the next batches). Normally clients should not do this, but malicious third-party can send such requests to DDOS iroha peer. In case limits are exceeded, iroha peer will return error "429 too many requests" for the query request.
Also:
Some notes about implementation:
mpsc::channel
, andLiveQueryStore
thread does the addition. I changed it to perform addition directly withoutmpsc::channel
since we now need to check capacity and return error to client if it exceeds.Linked issue
Closes #4830
Benefits
Add limit to number of live queries to prevent high memory usage in cases when client don't fully consume query output.
Checklist
CONTRIBUTING.md