Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(sumeragi): remove expired transaction from cache #4922

Merged
merged 2 commits into from
Jul 31, 2024
Merged

fix(sumeragi): remove expired transaction from cache #4922

merged 2 commits into from
Jul 31, 2024
+7 −7

Conversation

Erigara
Copy link
Contributor

@Erigara Erigara commented Jul 31, 2024

Description

  • fix a bug in retain that actually non expired transactions were removed
  • qol improvment to print transactions by hash in the logs
    • i find it really hard to debug iroha on TRACE level in presence of heavy transactions because all logs are polluted by tx printing

Benefits

  • fewer bugs
  • more clear logs

@Erigara Erigara added the Bug Something isn't working label Jul 31, 2024
@Erigara Erigara self-assigned this Jul 31, 2024
@Erigara Erigara changed the title fix(sumeragi): remove expired transaction from hash fix(sumeragi): remove expired transaction from cache Jul 31, 2024
@Erigara Erigara force-pushed the fix_sumeragi_cache branch from 8eb2aa3 to a228016 Compare July 31, 2024 07:22
@Erigara Erigara merged commit a62640d into hyperledger-iroha:main Jul 31, 2024
11 of 12 checks passed
mversic pushed a commit that referenced this pull request Aug 30, 2024
@Erigara @mversic
fix(sumeragi): remove expired transaction from cache (#4922)
5decae1 
Signed-off-by: Shanin Roman <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nxsaken nxsaken nxsaken approved these changes

@DCNick3 DCNick3 DCNick3 approved these changes

@s8sato s8sato Awaiting requested review from s8sato s8sato is a code owner

@mversic mversic Awaiting requested review from mversic mversic is a code owner

@SamHSmith SamHSmith Awaiting requested review from SamHSmith

@outoftardis outoftardis Awaiting requested review from outoftardis outoftardis is a code owner

@0x009922 0x009922 Awaiting requested review from 0x009922 0x009922 is a code owner

@dima74 dima74 Awaiting requested review from dima74 dima74 is a code owner

Assignees

@Erigara Erigara

Labels
Bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Erigara @DCNick3 @nxsaken