Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!: remove event_recommendations from block #4932

Merged

Conversation

mversic
Copy link
Contributor

@mversic mversic commented Aug 2, 2024

Description

removed event_recommendations from block. It was unused

Linked issue

Closes #{issue_number}

Benefits

Checklist

  • I've read CONTRIBUTING.md
  • I've used the standard signed-off commit format (or will squash just before merging)
  • All applicable CI checks pass (or I promised to make them pass later)
  • (optional) I've written unit tests for the code changes
  • I replied to all comments after code review, marking all implemented changes with thumbs up

@mversic mversic force-pushed the remove_event_recommendations branch from 014e705 to 2b1a49b Compare August 2, 2024 16:33
@github-actions github-actions bot added the api-changes Changes in the API for client libraries label Aug 2, 2024
@mversic mversic force-pushed the remove_event_recommendations branch 2 times, most recently from 46e06c7 to a3fdf44 Compare August 2, 2024 16:47
@mversic mversic changed the title reafactor!: remove event_recommendations from block refactor!: remove event_recommendations from block Aug 2, 2024
@mversic mversic self-assigned this Aug 2, 2024
Erigara
Erigara previously approved these changes Aug 2, 2024
@mversic mversic force-pushed the remove_event_recommendations branch from a3fdf44 to 264d8f5 Compare August 2, 2024 18:07
@mversic mversic requested a review from Erigara August 2, 2024 18:07
@s8sato s8sato self-assigned this Aug 5, 2024
@mversic mversic merged commit 58c943e into hyperledger-iroha:main Aug 5, 2024
12 of 13 checks passed
@mversic mversic deleted the remove_event_recommendations branch August 5, 2024 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api-changes Changes in the API for client libraries
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants