fix: Improve queue transactions handling #4947
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dima74
requested review from
s8sato,
mversic,
SamHSmith,
outoftardis,
Erigara,
0x009922 and
DCNick3
as code owners
github-actions
bot
added
the
config-changes
Erigara
reviewed
Aug 7, 2024
Erigara
reviewed
Aug 7, 2024
dima74
force-pushed
the
diralik/fix-unstable-tps-transactions-queue
branch
from
1eeda85 to
847f89b
Compare
Erigara
previously approved these changes
Aug 7, 2024
mversic
force-pushed
the
diralik/fix-unstable-tps-transactions-queue
branch
from
847f89b to
970cc02
Compare
mversic
reviewed
Aug 9, 2024
mversic
reviewed
Aug 9, 2024
dima74
force-pushed
the
diralik/fix-unstable-tps-transactions-queue
branch
from
970cc02 to
f919b68
Compare
mversic
reviewed
Aug 14, 2024
mversic
approved these changes
Aug 14, 2024
mversic
reviewed
Aug 14, 2024
mversic
approved these changes
Aug 14, 2024
|
failing tests |
Signed-off-by: Dmitry Murzin <[email protected]>
Signed-off-by: Dmitry Murzin <[email protected]>
Signed-off-by: Dmitry Murzin <[email protected]>
Signed-off-by: Dmitry Murzin <[email protected]>
dima74
force-pushed
the
diralik/fix-unstable-tps-transactions-queue
branch
from
fecfb81 to
d6800e3
Compare
mversic
approved these changes
Aug 15, 2024
mversic
pushed a commit
that referenced
this pull request
Aug 30, 2024
Signed-off-by: Dmitry Murzin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently in some cases tps numbers (transactions per second) may be very unstable for network of a single peer. See #4727 (comment) and #4727 (comment) for detailed description of the reasons. This PR adjusts how transactions are handled in the queue, so tps will be more stable. Note that average tps should not change (maybe slightly improvement).
Here is comparison of tps:
Linked issue
Related: #4727
Benefits
Improve stability of the tps in case when there are a lot of requests and transaction queue is full
Checklist
CONTRIBUTING.md