Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Simplify /health and /api_version #4960

Merged
merged 1 commit into from
Aug 9, 2024
Merged

refactor: Simplify /health and /api_version #4960

merged 1 commit into from
Aug 9, 2024

Conversation

dima74
Copy link
Contributor

@dima74 dima74 commented Aug 9, 2024

Description

Linked issue

Closes #4218

Benefits

Simplify API endpoints /health and /api_version

Checklist

  • I've read CONTRIBUTING.md
  • I've used the standard signed-off commit format (or will squash just before merging)
  • All applicable CI checks pass (or I promised to make them pass later)
  • (optional) I've written unit tests for the code changes
  • I replied to all comments after code review, marking all implemented changes with thumbs up

@dima74 dima74 self-assigned this Aug 9, 2024
@github-actions github-actions bot added the api-changes Changes in the API for client libraries label Aug 9, 2024
@mversic mversic merged commit 19687dc into hyperledger-iroha:main Aug 9, 2024
11 of 12 checks passed
@dima74 dima74 deleted the diralik/simplify-api-version-and-health branch August 14, 2024 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Erigara Erigara Erigara approved these changes

@mversic mversic mversic approved these changes

@s8sato s8sato Awaiting requested review from s8sato s8sato is a code owner

@SamHSmith SamHSmith Awaiting requested review from SamHSmith

@outoftardis outoftardis Awaiting requested review from outoftardis outoftardis is a code owner

@0x009922 0x009922 Awaiting requested review from 0x009922 0x009922 is a code owner

@DCNick3 DCNick3 Awaiting requested review from DCNick3 DCNick3 is a code owner

Assignees

@dima74 dima74

Labels
api-changes Changes in the API for client libraries
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[suggestion] Remove JSON encoding for API Version and Health requests, use plain text
3 participants
@dima74 @Erigara @mversic