perf: Don't validate transactions inside WASM

[dima74]

Context

I am investigating single peer tps performance (#4727), and it turns out that actual execution of wasm code takes most of the time per transaction (#3716 (comment)).

Solution

This PR removes validation of transactions at WASM side - there is no need to revalidate transaction which comes from Iroha Rust code. This gives approximately 50% tps increase (single peer). Also size of default executor is reduced from 492KB to 391KB.

Comparison of tps:

Fixes #4803
Related: #4727
Related: #3716

Checklist

• I've read CONTRIBUTING.md.
• (optional) I've written unit tests for the code changes.
• All review comments have been resolved.

[github-actions]

@BAStos525

[mversic]

I think you should apply this to all validate_*** methods in this crate

[mversic]

I think you should apply this to all validate_*** methods in this crate

you still didn't apply it to Name::validate_str

[mversic]

I think you should apply this to all validate_*** methods in this crate

you still didn't apply it to Name::validate_str

also Parameter, Trigger and event_set

[dima74]

• Removed validation for Name::validate_str
• For Parameter, the only validation is NonZeroUsize::try_from(/* NonZeroU64 */), I think it should be kept as is
• For Trigger there is method ActionCandidate::validate which does really small match check, and also is used in ActionCandidate::new. Do you think it is worth to change it?
• For event_set didn't find validation method, could you clarify?

[mversic]

• Removed validation for Name::validate_str

  • For Parameter, the only validation is NonZeroUsize::try_from(/* NonZeroU64 */), I think it should be kept as is

  • For Trigger there is method ActionCandidate::validate which does really small match check, and also is used in ActionCandidate::new. Do you think it is worth to change it?

  • For event_set didn't find validation method, could you clarify?

it's fine, I only looked around for deserialize functions

Can you update the numbers in the PR description?

[dima74]

Can you update the numbers in the PR description?

Updated executor size. Tps numbers remains the same