ci: use Nextest, remove broken rust-cache, more unit test coverage #4996
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nxsaken
force-pushed
the
ci/cargo-nextest
branch
7 times, most recently
from
e53bcc0 to
fdb4a40
Compare
nxsaken
changed the title
macos-latest and cargo nextest in PR workflow
nxsaken
force-pushed
the
ci/cargo-nextest
branch
from
bd34025 to
d9ea932
Compare
nxsaken
changed the title
macos-latest and cargo nextest in PR workflowmacos-latest and cargo nextest across CI
nxsaken
requested review from
s8sato,
mversic,
SamHSmith,
outoftardis,
Erigara,
0x009922,
DCNick3 and
dima74
as code owners
mversic
previously requested changes
Aug 26, 2024
nxsaken
force-pushed
the
ci/cargo-nextest
branch
2 times, most recently
from
7030338 to
77a431d
Compare
BAStos525
reviewed
Aug 28, 2024
BAStos525
previously approved these changes
Aug 28, 2024
Erigara
previously approved these changes
Aug 29, 2024
nxsaken
force-pushed
the
ci/cargo-nextest
branch
6 times, most recently
from
3b8376a to
6ff2fb9
Compare
BAStos525
reviewed
Sep 20, 2024
nxsaken
force-pushed
the
ci/cargo-nextest
branch
from
6ff2fb9 to
215fd43
Compare
BAStos525
requested changes
Sep 23, 2024
nxsaken
force-pushed
the
ci/cargo-nextest
branch
from
215fd43 to
9528c07
Compare
nxsaken
changed the title
cargo nextest
nxsaken
force-pushed
the
ci/cargo-nextest
branch
from
9528c07 to
d9cb4c0
Compare
BAStos525
reviewed
Sep 23, 2024
|
@BAStos525 UI tests fail with the disk space issue you've mentioned before, should they also use the self-hosted runners? |
Sure. We can try self-hosted runners |
BAStos525
force-pushed
the
ci/cargo-nextest
branch
from
d06127f to
29e683f
Compare
BAStos525
approved these changes
Sep 26, 2024
0x009922
approved these changes
Sep 30, 2024
0x009922
force-pushed
the
ci/cargo-nextest
branch
from
29e683f to
cdf0535
Compare
Signed-off-by: Nurzhan Sakén <[email protected]>
Signed-off-by: Nurzhan Sakén <[email protected]>
Signed-off-by: BAStos525 <[email protected]>
0x009922
force-pushed
the
ci/cargo-nextest
branch
from
cdf0535 to
462b8b1
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
This PR sets up
cargo nextestfor running Rust tests, and makes other CI-related improvements:no-default-features(closes Restore no-default-features unit tests #4854)Caching dependencies should actually work now (switch fromrust-cachetocargo-cache), cache is shared between similar jobscargo-cache, andrust-cachenever seems to hit the cache even though it writes to it.actions/setup-python@v5fails sometimes inI2::CI::check_for_incorrect_images#4499 (specifies the exact Ubuntu version)Checklist
CONTRIBUTING.md.