-
Notifications
You must be signed in to change notification settings - Fork 277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Change parameters format in genesis.json #5020
Merged
mversic
merged 3 commits into
hyperledger-iroha:main
from
dima74:diralik/change-parameter-genesis-json
Sep 9, 2024
Merged
refactor: Change parameters format in genesis.json #5020
mversic
merged 3 commits into
hyperledger-iroha:main
from
dima74:diralik/change-parameter-genesis-json
Sep 9, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dima74
commented
Aug 29, 2024
mversic
reviewed
Aug 30, 2024
mversic
previously approved these changes
Aug 30, 2024
mversic
approved these changes
Aug 31, 2024
mversic
requested changes
Aug 31, 2024
31dea9a
to
731d4c8
Compare
Erigara
reviewed
Sep 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No objections from codewise perspective and imo genesis this way looks more readable.
Let's see what SDK guys think: @Mingela @SamHSmith @0x009922
731d4c8
to
a344382
Compare
mversic
approved these changes
Sep 4, 2024
mversic
reviewed
Sep 4, 2024
a344382
to
33decf3
Compare
Erigara
approved these changes
Sep 9, 2024
Signed-off-by: Dmitry Murzin <[email protected]>
Signed-off-by: Dmitry Murzin <[email protected]>
Signed-off-by: Dmitry Murzin <[email protected]>
33decf3
to
6a8c4df
Compare
@BAStos525 @timofeevmd format of parameters in genesis.json has changed. Please see PR description for details of the new format. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
api-changes
Changes in the API for client libraries
config-changes
Changes in configuration and start up of the Iroha
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Fixes #4813
Solution
Changes format of
genesis.json
from (full format):to (full format):
Migration Guide (optional)
kagami genesis generate
will generate genesis in the new format. Custom genesis generator tools should be changed to new format.RawGenesisTransaction
corresponding to genesis.json fileReview notes (optional)
Checklist
CONTRIBUTING.md
.