refactor: Move total asset quantity to asset definition #5029
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
total_asset_quantity
map that we store is somewhat redundant and can be stored in the asset definition. This refactor allows us to removeFindTotalAssetQuantityByAssetDefinitionId
query, as the total asset quantity can be found by querying the asset definition itself.Closes #4934.
Solution
asset_total_quantities
map from WSVtotal_quantity
field to theAssetDefinition
FindTotalAssetQuantityByAssetDefinitionId
queryFindAssetsDefinitions
Migration Guide
FindTotalAssetQuantityByAssetDefinitionId
:Checklist
CONTRIBUTING.md
.