Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: introduce FindTriggers query, remove FindTriggerById #5040

Merged
merged 1 commit into from
Sep 10, 2024
Merged

refactor: introduce FindTriggers query, remove FindTriggerById #5040

merged 1 commit into from
Sep 10, 2024
+188 −105

Conversation

DCNick3
Copy link
Contributor

@DCNick3 DCNick3 commented Sep 9, 2024 •
edited
Loading

Context

Part of #4933.

Closes #5037.

Solution

  • Introduce FindTriggers query that can be used to retrieve all active triggers with their original wasm code and such
  • Remove FindTriggerById and replace its usages by FindTriggers
  • Leave FindActiveTriggerIds be until we have query projections

Migration Guide

FindTriggerById:

client
  .query(FindTriggers::new())
  .filter_with(|trigger| trigger.id.eq(needle_trigger_id))
  .execute_single()?

Checklist

  • I've read CONTRIBUTING.md.
  • All review comments have been resolved.
  • All CI checks pass.

@github-actions github-actions bot added the api-changes Changes in the API for client libraries label Sep 9, 2024
@s8sato s8sato self-assigned this Sep 9, 2024
@mversic mversic force-pushed the remove-find-trigger-by-id branch from fb0c553 to 5b3b91a Compare September 10, 2024 07:59
@mversic mversic merged commit 87f3dbd into hyperledger-iroha:main Sep 10, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Erigara Erigara Erigara approved these changes

@s8sato s8sato s8sato approved these changes

@mversic mversic Awaiting requested review from mversic mversic is a code owner

@SamHSmith SamHSmith Awaiting requested review from SamHSmith

@outoftardis outoftardis Awaiting requested review from outoftardis outoftardis is a code owner

@0x009922 0x009922 Awaiting requested review from 0x009922 0x009922 is a code owner

@dima74 dima74 Awaiting requested review from dima74 dima74 is a code owner

Assignees

@DCNick3 DCNick3

@Erigara Erigara

@s8sato s8sato

Labels
api-changes Changes in the API for client libraries
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Get rid of FindTriggerById
4 participants
@DCNick3 @Erigara @s8sato @mversic