refactor: rename JsonValue to Json #5154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mversic
requested review from
s8sato,
SamHSmith,
outoftardis,
Erigara,
0x009922,
DCNick3 and
dima74
as code owners
nxsaken
previously approved these changes
Oct 17, 2024
mversic
force-pushed
the
json_value_to_json
branch
from
b111551 to
096d19e
Compare
Signed-off-by: Marin Veršić <[email protected]>
mversic
force-pushed
the
json_value_to_json
branch
from
096d19e to
1bca257
Compare
0x009922
approved these changes
Oct 18, 2024
nxsaken
approved these changes
Oct 18, 2024
|
@mversic do we move it to "Done" as it was merged? |
QA should test and move to "Done" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow up to #5143. Just a simple rename of
JsonValueto more straightforwardJson