fix(core): Add checks for role presence before granting it

crates/iroha/tests/roles.rs

@@ -263,3 +263,16 @@ fn grant_revoke_role_permissions() -> Result<()> {
 
     Ok(())
 }
+
+#[test]
+#[should_panic(expected = "a peer exited unexpectedly")]
+fn grant_unexisting_role_in_genesis_fail() {
+    // Grant Alice UNEXISTING role
+    let alice_id = ALICE_ID.clone();
+    let role_id = "UNEXISTING".parse::<RoleId>().unwrap();
+    let grant_genesis_role = Grant::account_role(role_id, alice_id);
+
+    let _result = NetworkBuilder::new()
+        .with_genesis_instruction(grant_genesis_role)
+        .start_blocking();
+}

crates/iroha/tests/upgrade.rs

@@ -414,7 +414,7 @@ fn upgrade_executor(client: &Client, executor: impl AsRef<str>) -> Result<()> {
     if !profile.is_optimized() {
         client.submit_all_blocking::<InstructionBox>([InstructionBox::SetParameter(
             SetParameter::new(Parameter::Executor(SmartContractParameter::Fuel(
-                std::num::NonZeroU64::new(80_000_000_u64).expect("Fuel must be positive."),
+                std::num::NonZeroU64::new(90_000_000_u64).expect("Fuel must be positive."),
             ))),
         )])?;
     }

crates/iroha_core/src/smartcontracts/isi/account.rs

@@ -307,6 +307,7 @@ pub mod isi {
             let account_id = self.destination;
             let role_id = self.object;
 
+            state_transaction.world.role(&role_id)?;
             state_transaction.world.account(&account_id)?;
 
             if state_transaction

crates/iroha_core/src/state.rs

@@ -635,6 +635,18 @@ pub trait WorldReadOnly {
     fn asset_total_amount(&self, definition_id: &AssetDefinitionId) -> Result<Numeric, FindError> {
         Ok(self.asset_definition(definition_id)?.total_quantity)
     }
+
+    // Role-related methods
+
+    /// Get `Role` and return reference to it.
+    ///
+    /// # Errors
+    /// Fails if there is no role
+    fn role(&self, id: &RoleId) -> Result<&Role, FindError> {
+        self.roles()
+            .get(id)
+            .ok_or_else(|| FindError::Role(id.clone()))
+    }
 }
 
 macro_rules! impl_world_ro {