Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos in class FullDebugTraceInfo #2046

Merged
merged 2 commits into from
Apr 24, 2024

Conversation

hanmz
Copy link
Contributor

@hanmz hanmz commented Apr 23, 2024

What does this PR do?

Fix two typos in class FullDebugTraceInfo.
serReturnValye => setReturnValue

Why is it needed?

Improves readability

@hanmz hanmz requested review from gtebrean and NickSneo as code owners April 23, 2024 07:46
@rdovgan
Copy link

rdovgan commented Apr 23, 2024

Why it's serReturnValue not setReturnValue?

@hanmz
Copy link
Contributor Author

hanmz commented Apr 24, 2024

Why it's serReturnValue not setReturnValue?

Your are right, i fixed.

@NickSneo
Copy link
Contributor

@hanmz Thanks for contributing, btw you can create a single PR for all your changes and fixes.
Like in your previous PR only you can add this commit. It saves pipeline running time and easy to review all the changes at once

@NickSneo NickSneo merged commit f502b30 into hyperledger-web3j:main Apr 24, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants