Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web3j android #2110

Merged
Merged

Conversation

shashankiitbhu
Copy link

What does this PR do?

required

Where should the reviewer start?

required

Why is it needed?

required

Checklist

  • I've read the contribution guidelines.
  • I've added tests (if applicable).
  • I've added a changelog entry if necessary.

@shashankiitbhu shashankiitbhu changed the base branch from main to web3j-android December 2, 2024 15:51
shashankiitbhu and others added 25 commits December 2, 2024 21:48
Signed-off-by: Shashank Kumar <[email protected]>
Signed-off-by: Nischal Sharma <[email protected]>
Signed-off-by: Shashank Kumar <[email protected]>
Signed-off-by: gtebrean <[email protected]>
Signed-off-by: Shashank Kumar <[email protected]>
Signed-off-by: gtebrean <[email protected]>
Signed-off-by: Shashank Kumar <[email protected]>
Signed-off-by: gtebrean <[email protected]>
Signed-off-by: Shashank Kumar <[email protected]>
Signed-off-by: gtebrean <[email protected]>
Signed-off-by: Shashank Kumar <[email protected]>
Signed-off-by: gtebrean <[email protected]>
Signed-off-by: Shashank Kumar <[email protected]>
Signed-off-by: gtebrean <[email protected]>
Signed-off-by: Shashank Kumar <[email protected]>
Signed-off-by: gtebrean <[email protected]>
Signed-off-by: Shashank Kumar <[email protected]>
Signed-off-by: gtebrean <[email protected]>
Signed-off-by: Shashank Kumar <[email protected]>
Signed-off-by: gtebrean <[email protected]>
Signed-off-by: Shashank Kumar <[email protected]>
Signed-off-by: Nischal Sharma <[email protected]>
Signed-off-by: Shashank Kumar <[email protected]>
Signed-off-by: Nischal Sharma <[email protected]>
Signed-off-by: Shashank Kumar <[email protected]>
Signed-off-by: Nischal Sharma <[email protected]>
Signed-off-by: Shashank Kumar <[email protected]>
Signed-off-by: Nischal Sharma <[email protected]>
Signed-off-by: Shashank Kumar <[email protected]>
Signed-off-by: gtebrean <[email protected]>
Signed-off-by: Shashank Kumar <[email protected]>
Signed-off-by: gtebrean <[email protected]>
Signed-off-by: Shashank Kumar <[email protected]>
Signed-off-by: gtebrean <[email protected]>
Signed-off-by: Shashank Kumar <[email protected]>
Signed-off-by: Hanmz <[email protected]>
Signed-off-by: Shashank Kumar <[email protected]>
Signed-off-by: hanmz <[email protected]>
Signed-off-by: Shashank Kumar <[email protected]>
Signed-off-by: hanmz <[email protected]>
Signed-off-by: Shashank Kumar <[email protected]>
Signed-off-by: gtebrean <[email protected]>
Signed-off-by: Shashank Kumar <[email protected]>
Signed-off-by: gtebrean <[email protected]>
Signed-off-by: Shashank Kumar <[email protected]>
Signed-off-by: gtebrean <[email protected]>
Signed-off-by: Shashank Kumar <[email protected]>
Signed-off-by: gtebrean <[email protected]>
Signed-off-by: Shashank Kumar <[email protected]>
gtebrean and others added 25 commits December 2, 2024 21:48
Signed-off-by: gtebrean <[email protected]>
Signed-off-by: Shashank Kumar <[email protected]>
Signed-off-by: gtebrean <[email protected]>
Signed-off-by: Shashank Kumar <[email protected]>
)

* Bug fix for FastRawTransactionManager.resetNonce

Signed-off-by: Junsung Cho <[email protected]>

* Add check nonce after reset

Signed-off-by: Junsung Cho <[email protected]>

---------

Signed-off-by: Junsung Cho <[email protected]>
Signed-off-by: Shashank Kumar <[email protected]>
Signed-off-by: gtebrean <[email protected]>
Signed-off-by: Shashank Kumar <[email protected]>
Signed-off-by: gtebrean <[email protected]>
Signed-off-by: Shashank Kumar <[email protected]>
Signed-off-by: gtebrean <[email protected]>
Signed-off-by: Shashank Kumar <[email protected]>
Signed-off-by: gtebrean <[email protected]>
Signed-off-by: Shashank Kumar <[email protected]>
Signed-off-by: gtebrean <[email protected]>
Signed-off-by: Shashank Kumar <[email protected]>
Signed-off-by: gtebrean <[email protected]>
Signed-off-by: Shashank Kumar <[email protected]>
Signed-off-by: gtebrean <[email protected]>
Signed-off-by: Shashank Kumar <[email protected]>
Signed-off-by: Nischal Sharma <[email protected]>
Signed-off-by: Shashank Kumar <[email protected]>
Signed-off-by: Nischal Sharma <[email protected]>
Signed-off-by: Shashank Kumar <[email protected]>
Signed-off-by: Nischal Sharma <[email protected]>
Signed-off-by: Shashank Kumar <[email protected]>
Signed-off-by: Stefan Bratanov <[email protected]>
Signed-off-by: Shashank Kumar <[email protected]>
Signed-off-by: Stefan Bratanov <[email protected]>
Signed-off-by: Shashank Kumar <[email protected]>
* release 4.12.2

Signed-off-by: Nischal Sharma <[email protected]>

* bump snapshot version to 4.12.3

Signed-off-by: Nischal Sharma <[email protected]>

* Update CHANGELOG.md

Signed-off-by: Nischal Sharma <[email protected]>

---------

Signed-off-by: Nischal Sharma <[email protected]>
Signed-off-by: Shashank Kumar <[email protected]>
Signed-off-by: Shashank Kumar <[email protected]>
Signed-off-by: gtebrean <[email protected]>
Signed-off-by: Shashank Kumar <[email protected]>
Signed-off-by: gtebrean <[email protected]>
Signed-off-by: Shashank Kumar <[email protected]>
Signed-off-by: Shashank Kumar <[email protected]>
Signed-off-by: Shashank Kumar <[email protected]>
Signed-off-by: Shashank Kumar <[email protected]>
Signed-off-by: Shashank Kumar <[email protected]>
Signed-off-by: Shashank Kumar <[email protected]>
Comment on lines +14 to +17
compileOptions {
sourceCompatibility JavaVersion.VERSION_17
targetCompatibility JavaVersion.VERSION_17
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it fine to have these on version 17, I thought will run on java 8?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no this is necessary for some other library , I think we discussed it earler

Copy link
Contributor

@NickSneo NickSneo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, we need to add pipeline for raising PR against web3j-android

@gtebrean gtebrean merged commit bdbcdd7 into hyperledger-web3j:web3j-android Dec 3, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.