Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes #2120 - catch all exceptions during response parsing #2130

Merged
merged 2 commits into from
Dec 17, 2024

Conversation

Shohou
Copy link
Contributor

@Shohou Shohou commented Dec 16, 2024

What does this PR do?

fixes #2120

Where should the reviewer start?

At WebSocketService.java

Why is it needed?

to fix #2120

Checklist

  • I've read the contribution guidelines.
  • I've added tests (if applicable).
  • I've added a changelog entry if necessary.

@NickSneo
Copy link
Contributor

@Shohou Shohou force-pushed the 2120_all_exceptions branch from 863e8df to 4f9b494 Compare December 17, 2024 06:42
@Shohou Shohou force-pushed the 2120_all_exceptions branch from 4f9b494 to 5c19164 Compare December 17, 2024 06:46
@Shohou
Copy link
Contributor Author

Shohou commented Dec 17, 2024

@NickSneo done

Copy link
Contributor

@NickSneo NickSneo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gtebrean gtebrean merged commit 6785725 into hyperledger-web3j:main Dec 17, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Request send() hangs if response can not be parsed when using WebSocketService
3 participants