remove v0 version of the database #5698

matkt · 2023-07-12T13:28:37Z

PR description

This version of the database is not used anymore so we can remove it

Fixed Issue(s)

Signed-off-by: Karim TAAM <[email protected]>

github-actions · 2023-07-12T13:28:50Z

I thought about documentation and added the doc-change-required label to this PR if updates are required.
I thought about the changelog and included a changelog update if required.
If my PR includes database changes (e.g. KeyValueSegmentIdentifier) I have thought about compatibility and performed forwards and backwards compatibility tests

fab-10

LGTM, are you planning to release this in the next RC?
Please add a breaking change in the changelog

Signed-off-by: Karim TAAM <[email protected]>

matkt · 2023-07-12T16:53:53Z

LGTM, are you planning to release this in the next RC? Please add a breaking change in the changelog

yes I'm planning to add it . just updated the changelog

Signed-off-by: Karim TAAM <[email protected]>

fab-10

LGTM, just a rewording suggestion

fab-10 · 2023-07-12T16:59:32Z

CHANGELOG.md

@@ -5,6 +5,8 @@

 ### Breaking Changes

+- Deprecated version 0 of the database as it is no longer used by any active nodes.


Suggested change

- Deprecated version 0 of the database as it is no longer used by any active nodes.

- Removed support for version 0 of the database as it is no longer used by any active node.

garyschulte

🥳

looks like a couple more unit tests need 👀 though

garyschulte · 2023-07-12T18:04:31Z

we should also remove 0 from the SUPPORTED_VERSIONS Set in RocksDBKeyValueStorageFactory and (possibly) RocksDBKeyValuePrivacyStorageFactory

matkt · 2023-07-12T18:11:49Z

we should also remove 0 from the SUPPORTED_VERSIONS Set in RocksDBKeyValueStorageFactory and (possibly) RocksDBKeyValuePrivacyStorageFactory

fixing now @siladu could validate that it's ok for private network to remove 0 version ?

matkt · 2023-07-12T18:17:30Z

will start a sepolia node to validate this PR

Signed-off-by: Karim TAAM <[email protected]>

siladu

fixing now @siladu could validate that it's ok for private network to remove 0 version ?

Love a bit of code deletion :)

Seems fine to me, but would like @jframe or @macfarla to confirm too please.

siladu · 2023-07-12T22:31:19Z

.../core/src/jmh/java/org/hyperledger/besu/ethereum/vm/operations/OperationBenchmarkHelper.java

+    final OptimisticRocksDBColumnarKeyValueStorage optimisticRocksDBColumnarKeyValueStorage =
+        new OptimisticRocksDBColumnarKeyValueStorage(


Struggling to see the relevance of this change...KeyValueStorage still exists doesn't it? Or maybe we should delete KeyValueStorage too?

looks like the change is it's now a two step process - KeyValueStorage (which is the interface used by plugins) is created from this storage

yes we want to start a refactor of this part to be only segmented as we are only using that now. this one is the first PR and we will have more PRs after this one. We found a lot of code smell in this part when we wanted to change the code in order to have only one transaction to commit the worldstate

macfarla

LGTM

macfarla · 2023-07-13T01:17:40Z

.../core/src/jmh/java/org/hyperledger/besu/ethereum/vm/operations/OperationBenchmarkHelper.java

            new NoOpMetricsSystem(),
            RocksDBMetricsFactory.PUBLIC_ROCKS_DB_METRICS);

+    final KeyValueStorage keyValueStorage =


KeyValueStorage still used here @siladu

macfarla · 2023-07-13T01:21:22Z

.../core/src/jmh/java/org/hyperledger/besu/ethereum/vm/operations/OperationBenchmarkHelper.java

+    final OptimisticRocksDBColumnarKeyValueStorage optimisticRocksDBColumnarKeyValueStorage =
+        new OptimisticRocksDBColumnarKeyValueStorage(


looks like the change is it's now a two step process - KeyValueStorage (which is the interface used by plugins) is created from this storage

Signed-off-by: Karim TAAM <[email protected]>

Signed-off-by: Karim TAAM <[email protected]> Signed-off-by: Daniel Lehrner <[email protected]>

Signed-off-by: Karim TAAM <[email protected]> Signed-off-by: 0xBlockPay <[email protected]>

* Extend OperationTracer with new methods, create Signed-off-by: Daniel Lehrner <[email protected]> * Rename ExtendedOperationTracer to BlockAwareOperationTracer Signed-off-by: Daniel Lehrner <[email protected]> * fixed plugin api hash Signed-off-by: Daniel Lehrner <[email protected]> * added missing javadoc comments Signed-off-by: Daniel Lehrner <[email protected]> * Update evm/src/main/java/org/hyperledger/besu/evm/tracing/OperationTracer.java Co-authored-by: Sally MacFarlane <[email protected]> Signed-off-by: Daniel Lehrner <[email protected]> * Only update peer with the first and last block (#5659) * only update peer with the first and last block Signed-off-by: Stefan <[email protected]> Signed-off-by: Daniel Lehrner <[email protected]> * Put download links into CHANGELOG and do some clean up (#5660) * put the download links for 23.4.4 into the CHANGELOG.md * clean up CHANGELOG Signed-off-by: Stefan <[email protected]> Signed-off-by: Daniel Lehrner <[email protected]> * Add --amend to docker manifest create to fix docker latest tag (#5661) We need to replace previous release's latest tag. Might be broken due to a recent change in the docker command implementation Signed-off-by: Simon Dudley <[email protected]> Signed-off-by: Daniel Lehrner <[email protected]> * Add Xlayered-tx-pool to the config log printout (#5665) Unrelated: clarify epoch length in javadoc Signed-off-by: Simon Dudley <[email protected]> Co-authored-by: Gabriel Fukushima <[email protected]> Signed-off-by: Daniel Lehrner <[email protected]> * Add hooks to AbstractCreateOperation for library users (#5656) Add hooks for a successful contract create, a failed contract create, and an invalid contact create. Users of the library will be able to customize create responses without having to replace core logic. Signed-off-by: Danno Ferrin <[email protected]> Signed-off-by: Daniel Lehrner <[email protected]> * Test updates for cancun execution-spec-tests (#5670) - support legacy V values (larger V value) and type 1+ (v is recId only) - new fields - shared transaction extraction - rejection detection Signed-off-by: Danno Ferrin <[email protected]> Signed-off-by: Daniel Lehrner <[email protected]> * Upgrade BouncyCastle libraries (#5675) Upgrade bouncy castle to v1.75. This involved a change in maven coordinates for other modules. Signed-off-by: Danno Ferrin <[email protected]> Signed-off-by: Daniel Lehrner <[email protected]> * Introduce transaction validator interface (phase 1) (#5673) Signed-off-by: Fabio Di Fabio <[email protected]> Signed-off-by: Daniel Lehrner <[email protected]> * Only validate `--miner-enabled` option for ethash networks (#5669) * Modify the min-gas-price option validation * Check for whether ethash is in use, either from genesis or network config, and use that for miner checks * Add genesis configuration isPoa() convenience function --------- Signed-off-by: Matthew Whitehead <[email protected]> Signed-off-by: Matt Whitehead <[email protected]> Co-authored-by: Simon Dudley <[email protected]> Signed-off-by: Simon Dudley <[email protected]> Signed-off-by: Daniel Lehrner <[email protected]> * Update tuweni2.4.2 (#5684) * Revert "Revert "Update Tuweni to 2.4.1 (#5513)" (#5585)" This reverts commit 6111e1b. Signed-off-by: Antoine Toulme <[email protected]> * update Tuweni to 2.4.2 Signed-off-by: Antoine Toulme <[email protected]> --------- Signed-off-by: Antoine Toulme <[email protected]> Signed-off-by: Daniel Lehrner <[email protected]> * Do not leak references to PendingTransactions (#5693) Signed-off-by: Fabio Di Fabio <[email protected]> Signed-off-by: Daniel Lehrner <[email protected]> * remove v0 version of the database (#5698) Signed-off-by: Karim TAAM <[email protected]> Signed-off-by: Daniel Lehrner <[email protected]> * updated plugin api hash Signed-off-by: Daniel Lehrner <[email protected]> * spotless Signed-off-by: Daniel Lehrner <[email protected]> * updating plugin api hash Signed-off-by: Daniel Lehrner <[email protected]> * moved transcation interface to datatypes to use it in the OperationTracer.traceStartTransaction method Signed-off-by: Daniel Lehrner <[email protected]> * fix import Signed-off-by: Daniel Lehrner <[email protected]> --------- Signed-off-by: Daniel Lehrner <[email protected]> Signed-off-by: Stefan <[email protected]> Signed-off-by: Simon Dudley <[email protected]> Signed-off-by: Danno Ferrin <[email protected]> Signed-off-by: Fabio Di Fabio <[email protected]> Signed-off-by: Matthew Whitehead <[email protected]> Signed-off-by: Matt Whitehead <[email protected]> Signed-off-by: Antoine Toulme <[email protected]> Signed-off-by: Karim TAAM <[email protected]> Co-authored-by: Sally MacFarlane <[email protected]> Co-authored-by: Stefan Pingel <[email protected]> Co-authored-by: Simon Dudley <[email protected]> Co-authored-by: Gabriel Fukushima <[email protected]> Co-authored-by: Danno Ferrin <[email protected]> Co-authored-by: Fabio Di Fabio <[email protected]> Co-authored-by: Matt Whitehead <[email protected]> Co-authored-by: Antoine Toulme <[email protected]> Co-authored-by: matkt <[email protected]>

Signed-off-by: Karim TAAM <[email protected]>

* Extend OperationTracer with new methods, create Signed-off-by: Daniel Lehrner <[email protected]> * Rename ExtendedOperationTracer to BlockAwareOperationTracer Signed-off-by: Daniel Lehrner <[email protected]> * fixed plugin api hash Signed-off-by: Daniel Lehrner <[email protected]> * added missing javadoc comments Signed-off-by: Daniel Lehrner <[email protected]> * Update evm/src/main/java/org/hyperledger/besu/evm/tracing/OperationTracer.java Co-authored-by: Sally MacFarlane <[email protected]> Signed-off-by: Daniel Lehrner <[email protected]> * Only update peer with the first and last block (hyperledger#5659) * only update peer with the first and last block Signed-off-by: Stefan <[email protected]> Signed-off-by: Daniel Lehrner <[email protected]> * Put download links into CHANGELOG and do some clean up (hyperledger#5660) * put the download links for 23.4.4 into the CHANGELOG.md * clean up CHANGELOG Signed-off-by: Stefan <[email protected]> Signed-off-by: Daniel Lehrner <[email protected]> * Add --amend to docker manifest create to fix docker latest tag (hyperledger#5661) We need to replace previous release's latest tag. Might be broken due to a recent change in the docker command implementation Signed-off-by: Simon Dudley <[email protected]> Signed-off-by: Daniel Lehrner <[email protected]> * Add Xlayered-tx-pool to the config log printout (hyperledger#5665) Unrelated: clarify epoch length in javadoc Signed-off-by: Simon Dudley <[email protected]> Co-authored-by: Gabriel Fukushima <[email protected]> Signed-off-by: Daniel Lehrner <[email protected]> * Add hooks to AbstractCreateOperation for library users (hyperledger#5656) Add hooks for a successful contract create, a failed contract create, and an invalid contact create. Users of the library will be able to customize create responses without having to replace core logic. Signed-off-by: Danno Ferrin <[email protected]> Signed-off-by: Daniel Lehrner <[email protected]> * Test updates for cancun execution-spec-tests (hyperledger#5670) - support legacy V values (larger V value) and type 1+ (v is recId only) - new fields - shared transaction extraction - rejection detection Signed-off-by: Danno Ferrin <[email protected]> Signed-off-by: Daniel Lehrner <[email protected]> * Upgrade BouncyCastle libraries (hyperledger#5675) Upgrade bouncy castle to v1.75. This involved a change in maven coordinates for other modules. Signed-off-by: Danno Ferrin <[email protected]> Signed-off-by: Daniel Lehrner <[email protected]> * Introduce transaction validator interface (phase 1) (hyperledger#5673) Signed-off-by: Fabio Di Fabio <[email protected]> Signed-off-by: Daniel Lehrner <[email protected]> * Only validate `--miner-enabled` option for ethash networks (hyperledger#5669) * Modify the min-gas-price option validation * Check for whether ethash is in use, either from genesis or network config, and use that for miner checks * Add genesis configuration isPoa() convenience function --------- Signed-off-by: Matthew Whitehead <[email protected]> Signed-off-by: Matt Whitehead <[email protected]> Co-authored-by: Simon Dudley <[email protected]> Signed-off-by: Simon Dudley <[email protected]> Signed-off-by: Daniel Lehrner <[email protected]> * Update tuweni2.4.2 (hyperledger#5684) * Revert "Revert "Update Tuweni to 2.4.1 (hyperledger#5513)" (hyperledger#5585)" This reverts commit 6111e1b. Signed-off-by: Antoine Toulme <[email protected]> * update Tuweni to 2.4.2 Signed-off-by: Antoine Toulme <[email protected]> --------- Signed-off-by: Antoine Toulme <[email protected]> Signed-off-by: Daniel Lehrner <[email protected]> * Do not leak references to PendingTransactions (hyperledger#5693) Signed-off-by: Fabio Di Fabio <[email protected]> Signed-off-by: Daniel Lehrner <[email protected]> * remove v0 version of the database (hyperledger#5698) Signed-off-by: Karim TAAM <[email protected]> Signed-off-by: Daniel Lehrner <[email protected]> * updated plugin api hash Signed-off-by: Daniel Lehrner <[email protected]> * spotless Signed-off-by: Daniel Lehrner <[email protected]> * updating plugin api hash Signed-off-by: Daniel Lehrner <[email protected]> * moved transcation interface to datatypes to use it in the OperationTracer.traceStartTransaction method Signed-off-by: Daniel Lehrner <[email protected]> * fix import Signed-off-by: Daniel Lehrner <[email protected]> --------- Signed-off-by: Daniel Lehrner <[email protected]> Signed-off-by: Stefan <[email protected]> Signed-off-by: Simon Dudley <[email protected]> Signed-off-by: Danno Ferrin <[email protected]> Signed-off-by: Fabio Di Fabio <[email protected]> Signed-off-by: Matthew Whitehead <[email protected]> Signed-off-by: Matt Whitehead <[email protected]> Signed-off-by: Antoine Toulme <[email protected]> Signed-off-by: Karim TAAM <[email protected]> Co-authored-by: Sally MacFarlane <[email protected]> Co-authored-by: Stefan Pingel <[email protected]> Co-authored-by: Simon Dudley <[email protected]> Co-authored-by: Gabriel Fukushima <[email protected]> Co-authored-by: Danno Ferrin <[email protected]> Co-authored-by: Fabio Di Fabio <[email protected]> Co-authored-by: Matt Whitehead <[email protected]> Co-authored-by: Antoine Toulme <[email protected]> Co-authored-by: matkt <[email protected]>

This reverts commit 47a817b.

Signed-off-by: Karim TAAM <[email protected]>

* Extend OperationTracer with new methods, create Signed-off-by: Daniel Lehrner <[email protected]> * Rename ExtendedOperationTracer to BlockAwareOperationTracer Signed-off-by: Daniel Lehrner <[email protected]> * fixed plugin api hash Signed-off-by: Daniel Lehrner <[email protected]> * added missing javadoc comments Signed-off-by: Daniel Lehrner <[email protected]> * Update evm/src/main/java/org/hyperledger/besu/evm/tracing/OperationTracer.java Co-authored-by: Sally MacFarlane <[email protected]> Signed-off-by: Daniel Lehrner <[email protected]> * Only update peer with the first and last block (hyperledger#5659) * only update peer with the first and last block Signed-off-by: Stefan <[email protected]> Signed-off-by: Daniel Lehrner <[email protected]> * Put download links into CHANGELOG and do some clean up (hyperledger#5660) * put the download links for 23.4.4 into the CHANGELOG.md * clean up CHANGELOG Signed-off-by: Stefan <[email protected]> Signed-off-by: Daniel Lehrner <[email protected]> * Add --amend to docker manifest create to fix docker latest tag (hyperledger#5661) We need to replace previous release's latest tag. Might be broken due to a recent change in the docker command implementation Signed-off-by: Simon Dudley <[email protected]> Signed-off-by: Daniel Lehrner <[email protected]> * Add Xlayered-tx-pool to the config log printout (hyperledger#5665) Unrelated: clarify epoch length in javadoc Signed-off-by: Simon Dudley <[email protected]> Co-authored-by: Gabriel Fukushima <[email protected]> Signed-off-by: Daniel Lehrner <[email protected]> * Add hooks to AbstractCreateOperation for library users (hyperledger#5656) Add hooks for a successful contract create, a failed contract create, and an invalid contact create. Users of the library will be able to customize create responses without having to replace core logic. Signed-off-by: Danno Ferrin <[email protected]> Signed-off-by: Daniel Lehrner <[email protected]> * Test updates for cancun execution-spec-tests (hyperledger#5670) - support legacy V values (larger V value) and type 1+ (v is recId only) - new fields - shared transaction extraction - rejection detection Signed-off-by: Danno Ferrin <[email protected]> Signed-off-by: Daniel Lehrner <[email protected]> * Upgrade BouncyCastle libraries (hyperledger#5675) Upgrade bouncy castle to v1.75. This involved a change in maven coordinates for other modules. Signed-off-by: Danno Ferrin <[email protected]> Signed-off-by: Daniel Lehrner <[email protected]> * Introduce transaction validator interface (phase 1) (hyperledger#5673) Signed-off-by: Fabio Di Fabio <[email protected]> Signed-off-by: Daniel Lehrner <[email protected]> * Only validate `--miner-enabled` option for ethash networks (hyperledger#5669) * Modify the min-gas-price option validation * Check for whether ethash is in use, either from genesis or network config, and use that for miner checks * Add genesis configuration isPoa() convenience function --------- Signed-off-by: Matthew Whitehead <[email protected]> Signed-off-by: Matt Whitehead <[email protected]> Co-authored-by: Simon Dudley <[email protected]> Signed-off-by: Simon Dudley <[email protected]> Signed-off-by: Daniel Lehrner <[email protected]> * Update tuweni2.4.2 (hyperledger#5684) * Revert "Revert "Update Tuweni to 2.4.1 (hyperledger#5513)" (hyperledger#5585)" This reverts commit 6111e1b. Signed-off-by: Antoine Toulme <[email protected]> * update Tuweni to 2.4.2 Signed-off-by: Antoine Toulme <[email protected]> --------- Signed-off-by: Antoine Toulme <[email protected]> Signed-off-by: Daniel Lehrner <[email protected]> * Do not leak references to PendingTransactions (hyperledger#5693) Signed-off-by: Fabio Di Fabio <[email protected]> Signed-off-by: Daniel Lehrner <[email protected]> * remove v0 version of the database (hyperledger#5698) Signed-off-by: Karim TAAM <[email protected]> Signed-off-by: Daniel Lehrner <[email protected]> * updated plugin api hash Signed-off-by: Daniel Lehrner <[email protected]> * spotless Signed-off-by: Daniel Lehrner <[email protected]> * updating plugin api hash Signed-off-by: Daniel Lehrner <[email protected]> * moved transcation interface to datatypes to use it in the OperationTracer.traceStartTransaction method Signed-off-by: Daniel Lehrner <[email protected]> * fix import Signed-off-by: Daniel Lehrner <[email protected]> --------- Signed-off-by: Daniel Lehrner <[email protected]> Signed-off-by: Stefan <[email protected]> Signed-off-by: Simon Dudley <[email protected]> Signed-off-by: Danno Ferrin <[email protected]> Signed-off-by: Fabio Di Fabio <[email protected]> Signed-off-by: Matthew Whitehead <[email protected]> Signed-off-by: Matt Whitehead <[email protected]> Signed-off-by: Antoine Toulme <[email protected]> Signed-off-by: Karim TAAM <[email protected]> Co-authored-by: Sally MacFarlane <[email protected]> Co-authored-by: Stefan Pingel <[email protected]> Co-authored-by: Simon Dudley <[email protected]> Co-authored-by: Gabriel Fukushima <[email protected]> Co-authored-by: Danno Ferrin <[email protected]> Co-authored-by: Fabio Di Fabio <[email protected]> Co-authored-by: Matt Whitehead <[email protected]> Co-authored-by: Antoine Toulme <[email protected]> Co-authored-by: matkt <[email protected]>

Signed-off-by: Karim TAAM <[email protected]>

* Extend OperationTracer with new methods, create Signed-off-by: Daniel Lehrner <[email protected]> * Rename ExtendedOperationTracer to BlockAwareOperationTracer Signed-off-by: Daniel Lehrner <[email protected]> * fixed plugin api hash Signed-off-by: Daniel Lehrner <[email protected]> * added missing javadoc comments Signed-off-by: Daniel Lehrner <[email protected]> * Update evm/src/main/java/org/hyperledger/besu/evm/tracing/OperationTracer.java Co-authored-by: Sally MacFarlane <[email protected]> Signed-off-by: Daniel Lehrner <[email protected]> * Only update peer with the first and last block (hyperledger#5659) * only update peer with the first and last block Signed-off-by: Stefan <[email protected]> Signed-off-by: Daniel Lehrner <[email protected]> * Put download links into CHANGELOG and do some clean up (hyperledger#5660) * put the download links for 23.4.4 into the CHANGELOG.md * clean up CHANGELOG Signed-off-by: Stefan <[email protected]> Signed-off-by: Daniel Lehrner <[email protected]> * Add --amend to docker manifest create to fix docker latest tag (hyperledger#5661) We need to replace previous release's latest tag. Might be broken due to a recent change in the docker command implementation Signed-off-by: Simon Dudley <[email protected]> Signed-off-by: Daniel Lehrner <[email protected]> * Add Xlayered-tx-pool to the config log printout (hyperledger#5665) Unrelated: clarify epoch length in javadoc Signed-off-by: Simon Dudley <[email protected]> Co-authored-by: Gabriel Fukushima <[email protected]> Signed-off-by: Daniel Lehrner <[email protected]> * Add hooks to AbstractCreateOperation for library users (hyperledger#5656) Add hooks for a successful contract create, a failed contract create, and an invalid contact create. Users of the library will be able to customize create responses without having to replace core logic. Signed-off-by: Danno Ferrin <[email protected]> Signed-off-by: Daniel Lehrner <[email protected]> * Test updates for cancun execution-spec-tests (hyperledger#5670) - support legacy V values (larger V value) and type 1+ (v is recId only) - new fields - shared transaction extraction - rejection detection Signed-off-by: Danno Ferrin <[email protected]> Signed-off-by: Daniel Lehrner <[email protected]> * Upgrade BouncyCastle libraries (hyperledger#5675) Upgrade bouncy castle to v1.75. This involved a change in maven coordinates for other modules. Signed-off-by: Danno Ferrin <[email protected]> Signed-off-by: Daniel Lehrner <[email protected]> * Introduce transaction validator interface (phase 1) (hyperledger#5673) Signed-off-by: Fabio Di Fabio <[email protected]> Signed-off-by: Daniel Lehrner <[email protected]> * Only validate `--miner-enabled` option for ethash networks (hyperledger#5669) * Modify the min-gas-price option validation * Check for whether ethash is in use, either from genesis or network config, and use that for miner checks * Add genesis configuration isPoa() convenience function --------- Signed-off-by: Matthew Whitehead <[email protected]> Signed-off-by: Matt Whitehead <[email protected]> Co-authored-by: Simon Dudley <[email protected]> Signed-off-by: Simon Dudley <[email protected]> Signed-off-by: Daniel Lehrner <[email protected]> * Update tuweni2.4.2 (hyperledger#5684) * Revert "Revert "Update Tuweni to 2.4.1 (hyperledger#5513)" (hyperledger#5585)" This reverts commit 6111e1b. Signed-off-by: Antoine Toulme <[email protected]> * update Tuweni to 2.4.2 Signed-off-by: Antoine Toulme <[email protected]> --------- Signed-off-by: Antoine Toulme <[email protected]> Signed-off-by: Daniel Lehrner <[email protected]> * Do not leak references to PendingTransactions (hyperledger#5693) Signed-off-by: Fabio Di Fabio <[email protected]> Signed-off-by: Daniel Lehrner <[email protected]> * remove v0 version of the database (hyperledger#5698) Signed-off-by: Karim TAAM <[email protected]> Signed-off-by: Daniel Lehrner <[email protected]> * updated plugin api hash Signed-off-by: Daniel Lehrner <[email protected]> * spotless Signed-off-by: Daniel Lehrner <[email protected]> * updating plugin api hash Signed-off-by: Daniel Lehrner <[email protected]> * moved transcation interface to datatypes to use it in the OperationTracer.traceStartTransaction method Signed-off-by: Daniel Lehrner <[email protected]> * fix import Signed-off-by: Daniel Lehrner <[email protected]> --------- Signed-off-by: Daniel Lehrner <[email protected]> Signed-off-by: Stefan <[email protected]> Signed-off-by: Simon Dudley <[email protected]> Signed-off-by: Danno Ferrin <[email protected]> Signed-off-by: Fabio Di Fabio <[email protected]> Signed-off-by: Matthew Whitehead <[email protected]> Signed-off-by: Matt Whitehead <[email protected]> Signed-off-by: Antoine Toulme <[email protected]> Signed-off-by: Karim TAAM <[email protected]> Co-authored-by: Sally MacFarlane <[email protected]> Co-authored-by: Stefan Pingel <[email protected]> Co-authored-by: Simon Dudley <[email protected]> Co-authored-by: Gabriel Fukushima <[email protected]> Co-authored-by: Danno Ferrin <[email protected]> Co-authored-by: Fabio Di Fabio <[email protected]> Co-authored-by: Matt Whitehead <[email protected]> Co-authored-by: Antoine Toulme <[email protected]> Co-authored-by: matkt <[email protected]>

remove v0

4abbb3e

Signed-off-by: Karim TAAM <[email protected]>

matkt closed this Jul 12, 2023

fab-10 reviewed Jul 12, 2023

View reviewed changes

update tests

0a8f8d2

Signed-off-by: Karim TAAM <[email protected]>

matkt reopened this Jul 12, 2023

add breaking change

225f591

Signed-off-by: Karim TAAM <[email protected]>

fab-10 approved these changes Jul 12, 2023

View reviewed changes

garyschulte approved these changes Jul 12, 2023

View reviewed changes

matkt requested a review from siladu July 12, 2023 18:11

fixing build

7c7bf00

Signed-off-by: Karim TAAM <[email protected]>

siladu reviewed Jul 12, 2023

View reviewed changes

macfarla approved these changes Jul 13, 2023

View reviewed changes

Merge branch 'main' into feature/deprecated-database-v0

08c10e3

matkt enabled auto-merge (squash) July 13, 2023 13:14

matkt merged commit 9f42a3f into hyperledger:main Jul 13, 2023

daniellehrner pushed a commit to daniellehrner/besu that referenced this pull request Jul 13, 2023

remove v0 version of the database (hyperledger#5698)

0a1c407

Signed-off-by: Karim TAAM <[email protected]>

daniellehrner pushed a commit to daniellehrner/besu that referenced this pull request Jul 13, 2023

remove v0 version of the database (hyperledger#5698)

ccab3fb

Signed-off-by: Karim TAAM <[email protected]> Signed-off-by: Daniel Lehrner <[email protected]>

0xBlockPay pushed a commit to 0xBlockPay/besu that referenced this pull request Jul 17, 2023

remove v0 version of the database (hyperledger#5698)

7d28c13

Signed-off-by: Karim TAAM <[email protected]> Signed-off-by: 0xBlockPay <[email protected]>

davidkngo pushed a commit to liquichain/besu that referenced this pull request Jul 21, 2023

remove v0 version of the database (hyperledger#5698)

47a817b

Signed-off-by: Karim TAAM <[email protected]>

davidkngo added a commit to liquichain/besu that referenced this pull request Jul 21, 2023

Revert "remove v0 version of the database (hyperledger#5698)"

67d9912

This reverts commit 47a817b.

elenduuche pushed a commit to elenduuche/besu that referenced this pull request Aug 16, 2023

remove v0 version of the database (hyperledger#5698)

4951ffe

Signed-off-by: Karim TAAM <[email protected]>

matkt deleted the feature/deprecated-database-v0 branch September 22, 2023 09:39

eum602 pushed a commit to lacchain/besu that referenced this pull request Nov 3, 2023

remove v0 version of the database (hyperledger#5698)

e9126b7

Signed-off-by: Karim TAAM <[email protected]>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

remove v0 version of the database #5698

remove v0 version of the database #5698

matkt commented Jul 12, 2023

github-actions bot commented Jul 12, 2023

fab-10 left a comment

matkt commented Jul 12, 2023 •

edited

Loading

fab-10 left a comment

fab-10 Jul 12, 2023

matkt Jul 12, 2023

garyschulte left a comment •

edited

Loading

garyschulte commented Jul 12, 2023 •

edited

Loading

matkt commented Jul 12, 2023

matkt commented Jul 12, 2023

siladu left a comment •

edited

Loading

siladu Jul 12, 2023

macfarla Jul 13, 2023

matkt Jul 13, 2023

macfarla left a comment

macfarla Jul 13, 2023

macfarla Jul 13, 2023

		@@ -5,6 +5,8 @@

		### Breaking Changes

		- Deprecated version 0 of the database as it is no longer used by any active nodes.

	- Deprecated version 0 of the database as it is no longer used by any active nodes.
	- Removed support for version 0 of the database as it is no longer used by any active node.

		final OptimisticRocksDBColumnarKeyValueStorage optimisticRocksDBColumnarKeyValueStorage =
		new OptimisticRocksDBColumnarKeyValueStorage(

remove v0 version of the database #5698

remove v0 version of the database #5698

Conversation

matkt commented Jul 12, 2023

PR description

Fixed Issue(s)

github-actions bot commented Jul 12, 2023

fab-10 left a comment

Choose a reason for hiding this comment

matkt commented Jul 12, 2023 • edited Loading

fab-10 left a comment

Choose a reason for hiding this comment

fab-10 Jul 12, 2023

Choose a reason for hiding this comment

matkt Jul 12, 2023

Choose a reason for hiding this comment

garyschulte left a comment • edited Loading

Choose a reason for hiding this comment

garyschulte commented Jul 12, 2023 • edited Loading

matkt commented Jul 12, 2023

matkt commented Jul 12, 2023

siladu left a comment • edited Loading

Choose a reason for hiding this comment

siladu Jul 12, 2023

Choose a reason for hiding this comment

macfarla Jul 13, 2023

Choose a reason for hiding this comment

matkt Jul 13, 2023

Choose a reason for hiding this comment

macfarla left a comment

Choose a reason for hiding this comment

macfarla Jul 13, 2023

Choose a reason for hiding this comment

macfarla Jul 13, 2023

Choose a reason for hiding this comment

matkt commented Jul 12, 2023 •

edited

Loading

garyschulte left a comment •

edited

Loading

garyschulte commented Jul 12, 2023 •

edited

Loading

siladu left a comment •

edited

Loading