Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate runner for amd64 and arm64 #446

Merged
merged 1 commit into from
Feb 8, 2025

Conversation

denyeart
Copy link
Contributor

@denyeart denyeart commented Feb 8, 2025

Previously arm64 images were created on a standard amd64 runner using qemu. qemu emulation is very slow and there have been recent issues. Native image creation is faster and more reliable.

This change creates separate runners for amd64 (ubuntu-22.04) and arm64 (ubuntu-22.04-arm). Since ubuntu-20.04-arm runner is not available, binaries and images will be built with ubuntu-22.04.

A new job is then needed to combine the image digests into a multi-architecture manifest that gets pushed to Docker Hub and ghcr.

The approach is copied from core fabric repository.

Previously arm64 images were created on a standard amd64 runner using qemu.
qemu emulation is very slow and there have been recent issues.
Native image creation is faster and more reliable.

This change creates separate runners for amd64 (ubuntu-22.04) and arm64 (ubuntu-22.04-arm).

A new job is then needed to combine the image digests into a multi-architecture manifest that gets pushed to Docker Hub and ghcr.

The approach is copied from core fabric repository.

Signed-off-by: David Enyeart <[email protected]>
@denyeart denyeart requested a review from a team as a code owner February 8, 2025 04:30
@denyeart
Copy link
Contributor Author

denyeart commented Feb 8, 2025

Since release approach is already used in core fabric, and no code changes made, I'll go ahead and merge and release v1.5.15.

@denyeart denyeart merged commit 256fdbe into hyperledger:main Feb 8, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant