-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Setup basic HA features for the Peers #532
Conversation
@jkneubuh this should be workable today. Any thoughts appreciated... I wasn't sure about the new label naming.. so suggestions welcome |
I suggest changing the service name to ${org}-peer-gateway-svc, or some position to include 'gateway' in the name. It's hard to differentiate between org1-peer1 and org1-peer-svc. For the selector labels, maybe switch from On the ipvs attribute for the cluster config ... I think this is OK but I wonder if you encountered any issues when running on a Windows host? Since this enables features that are implemented in the Docker container it should be OK. |
Yes - good suggestions... #
|
9ddb75b
to
25fb0ae
Compare
- Add a new label to each peer to mark which org it is in - Create new service per org, that matches this label - so the service can pick from one of multiple pods - Update the kubeproxy to give more choice of ha stratergies - Update the application configmaps and samples to refer to this new service rather than specific peers Signed-off-by: Matthew B White <[email protected]>
25fb0ae
to
5f0da48
Compare
@jkneubuh updates made - now with a README :-) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is amazing.
K8s does a great job of offloading the gateway connection failover, client load balancing, and discovery with an "out of the box" configuration. This solution is simple, effective, and clear.
I approve!
Signed-off-by: Matthew B White [email protected]