Change executor service defaults (release-2.2) #242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bestbeforetoday
force-pushed
the
executor-2.2
branch
4 times, most recently
from
8e2b756 to
6f9373e
Compare
- Set the default core and maximum thread pool size to Runtime.getRuntime().availableProcessors() + 1. - Use a fixed thread pool using the larger of core or maximum thread pool, and an unbounded queue to prevent failures submitting work when all threads are in use. - Make HFClient.getExecutorService() public. The default (effectively) unlimited thread pool size with blocking queue could cause so many threads to be created under high event load that system failures could occur. Signed-off-by: Mark S. Lewis <[email protected]>
bestbeforetoday
force-pushed
the
executor-2.2
branch
from
6f9373e to
1a3c51e
Compare
andrew-coleman
approved these changes
Nov 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default (effectively) unlimited thread pool size could cause so many threads to be created under high event load that system failures could occur.