Define endorseTimeout value in fabric-sdk-node v1.4(Issue #552) #565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
takayuki-nagai
force-pushed
the
release-1.4
branch
from
5e84580 to
940a07e
Compare
…#552) In fabric-sdk-node v1.4, as well as in v2.2, define "endorseTimeout" value and use it instead of "commitTimeout". Co-Authored-by: Shinsuke Hasegawa <[email protected]> Signed-off-by: takayuki-nagai <[email protected]>
takayuki-nagai
force-pushed
the
release-1.4
branch
from
940a07e to
29b55d9
Compare
bestbeforetoday
requested changes
Apr 27, 2022
fabric-network/test/transaction.js
Outdated
| await transaction.submit(); | ||
| sinon.assert.calledWith(channel.sendTransactionProposal, sinon.match(expectedProposal), 999000); | ||
| }); | ||
|
|
||
| it('sends proposal with short timeout', async () => { | ||
| stubContract.getEventHandlerOptions.returns({commitTimeout: 3}); | ||
| stubContract.getEventHandlerOptions.returns({endorseTimeout: 3}); |
There was a problem hiding this comment.
This test seems intended to ensure the specified timeout did not drop below the commitTimeout value. The code no longer behaves this way, and I think your new behaviour is reasonable, so I suggest just removing this test entirely. The behaviour it is testing is already covered by the previous unit test.
fabric-network/test/transaction.js
Outdated
| @@ -301,15 +301,15 @@ describe('Transaction', () => { | |||
| }); | |||
|
|
|||
| it('sends proposal with long timeout', async () => { | |||
There was a problem hiding this comment.
With the new behaviour, this test might be better named.
Suggested change
| it('sends proposal with long timeout', async () => { | |
| it('uses endorseTimeout option as proposal timeout', async () => { |
There was a problem hiding this comment.
Thanks for your comment. I'll reflect your advice in the source code.
…#552) In fabric-sdk-node v1.4, as well as in v2.2, define "endorseTimeout" value and use it instead of "commitTimeout". Co-Authored-by: Shinsuke Hasegawa <[email protected]> Signed-off-by: takayuki-nagai <[email protected]>
takayuki-nagai
force-pushed
the
release-1.4
branch
from
5a71b85 to
67bc4d5
Compare
bestbeforetoday
approved these changes
Apr 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In fabric-sdk-node v1.4, as well as in v2.2, define "endorseTimeout" value and use it instead of commitTimeout.
Co-Authored-by: Shinsuke Hasegawa [email protected]
Signed-off-by: takayuki-nagai [email protected]
Closes #552