Add testing with Node 18 (release-2.2) #625
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bestbeforetoday
force-pushed
the
node18-2.2
branch
4 times, most recently
from
a57ddee to
03e0bed
Compare
@ampretia/x509 package does not work with Node 18 so changed to use jsrsasign to decode X.509 certificates in tests. This mostly works fine but seems to truncate non-standard extension values so some testing for custom attributes in CA enrollment are commented out for now. Signed-off-by: Mark S. Lewis <[email protected]>
bestbeforetoday
force-pushed
the
node18-2.2
branch
from
03e0bed to
222fc98
Compare
andrew-coleman
approved these changes
Nov 23, 2022
This was referenced Jun 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ampretia/x509 package does not work with Node 18 so changed to use jsrsasign to decode X.509 certificates in tests. This mostly works fine but seems to truncate non-standard extension values so some testing for custom attributes in CA enrollment are commented out for now.
Contributes to #621