Skip to content

Commit

Permalink
Fix the fix for race condition in Finder unit test (#2504)
Browse files Browse the repository at this point in the history
At the end of the unit test, correctly stop the goroutine used to ensure that commit messages are available to read at the point the listener attaches.

Signed-off-by: Mark S. Lewis <[email protected]>
  • Loading branch information
bestbeforetoday authored Mar 24, 2021
1 parent 1147977 commit 576d186
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions internal/pkg/gateway/commit/finder_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ func TestFinder(t *testing.T) {
select {
case commitSend <- msg:
case <-done:
return
}
}
}()
Expand Down

0 comments on commit 576d186

Please sign in to comment.