construct unreconciled missing pvtdata #1699
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cendhu
force-pushed
the
pass-missing-data-info
branch
from
9352d62 to
f63f517
Compare
gossip/privdata/reconcile.go
Outdated
Comment on lines
320
to
321
| func constructUnreconciledMissingData(requestedMissingData privdatacommon.Dig2CollectionConfig, fetchedData []*protosgossip.PvtDataElement) ledger.MissingPvtDataInfo { | ||
| remainingRequestedData := requestedMissingData |
There was a problem hiding this comment.
The name of the function does not indicate that the original input will be modified. If that's the intention, I would suggest to call it this function as removeFetchedData and do not return anything - instead let the caller prepared the MissingPvtDataInfo object.
There was a problem hiding this comment.
Yes. It does not sound good to manipulate the requested data. I have avoided removing entries from the requested data while constructing the unreconciled missing data.
Signed-off-by: senthil <[email protected]>
cendhu
force-pushed
the
pass-missing-data-info
branch
from
f63f517 to
25ed6f8
Compare
manish-sethi
approved these changes
Aug 10, 2020
|
@Mergifyio backport release-2.2 |
|
Command
|
mergify bot
pushed a commit
that referenced
this pull request
Sep 8, 2020
Signed-off-by: senthil <[email protected]> (cherry picked from commit 8c955ea)
cendhu
added a commit
to cendhu/fabric
that referenced
this pull request
Sep 8, 2020
Signed-off-by: senthil <[email protected]>
cendhu
added a commit
to cendhu/fabric
that referenced
this pull request
Sep 9, 2020
Signed-off-by: senthil <[email protected]>
denyeart
pushed a commit
that referenced
this pull request
Sep 16, 2020
Signed-off-by: senthil <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description
This PR adds a utility function to construct unreconciled missing pvtdata.
Additional details
This utility function would be used by the reconciler to inform ledger about the unreconciled missing pvtdata. This information would be used by the pvtdata store to deprioritize these missing pvtdata and retried after N iterations of reconciliation.
TxId field present in some of the structs defined in the reconciler/puller is not used. As some involve proto messages, it is not straightforward to remove it (due to rolling upgrade and change in the message format).