FAB-18163 TLS Timeshift w/o Separate Cluster Port #1724
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The existing orderer code allows for a TLS timeshift to be specified when starting the orderer with a separate cluster port. This is useful for situations where the consenter TLS certificates have accidentally expired, preventing quorum from forming, and preventing channel config updates to replace these certificates. This change extends the concept to the general orderer port, which can be optionally re-used, rather than binding to a new port. If the cluster port is not re-used, then the TLS timeshift parameter specified in the general TLS section takes precdence over the parameter specified in the cluster section. Likewise, if there is a separate cluster port, the parameter in the general TLS section has no impact on the cluster listener. Signed-off-by: Jason Yellick <[email protected]>
yacovm
approved these changes
Aug 14, 2020
|
@Mergifyio backport release-2.2 |
mergify bot
pushed a commit
that referenced
this pull request
Aug 14, 2020
The existing orderer code allows for a TLS timeshift to be specified when starting the orderer with a separate cluster port. This is useful for situations where the consenter TLS certificates have accidentally expired, preventing quorum from forming, and preventing channel config updates to replace these certificates. This change extends the concept to the general orderer port, which can be optionally re-used, rather than binding to a new port. If the cluster port is not re-used, then the TLS timeshift parameter specified in the general TLS section takes precdence over the parameter specified in the cluster section. Likewise, if there is a separate cluster port, the parameter in the general TLS section has no impact on the cluster listener. Signed-off-by: Jason Yellick <[email protected]> (cherry picked from commit 5d07186)
|
Command
|
jyellick
pushed a commit
that referenced
this pull request
Aug 14, 2020
The existing orderer code allows for a TLS timeshift to be specified when starting the orderer with a separate cluster port. This is useful for situations where the consenter TLS certificates have accidentally expired, preventing quorum from forming, and preventing channel config updates to replace these certificates. This change extends the concept to the general orderer port, which can be optionally re-used, rather than binding to a new port. If the cluster port is not re-used, then the TLS timeshift parameter specified in the general TLS section takes precdence over the parameter specified in the cluster section. Likewise, if there is a separate cluster port, the parameter in the general TLS section has no impact on the cluster listener. Signed-off-by: Jason Yellick <[email protected]> (cherry picked from commit 5d07186) Co-authored-by: Jason Yellick <[email protected]>
|
@Mergifyio backport release-2.1 |
mergify bot
pushed a commit
that referenced
this pull request
Aug 14, 2020
The existing orderer code allows for a TLS timeshift to be specified when starting the orderer with a separate cluster port. This is useful for situations where the consenter TLS certificates have accidentally expired, preventing quorum from forming, and preventing channel config updates to replace these certificates. This change extends the concept to the general orderer port, which can be optionally re-used, rather than binding to a new port. If the cluster port is not re-used, then the TLS timeshift parameter specified in the general TLS section takes precdence over the parameter specified in the cluster section. Likewise, if there is a separate cluster port, the parameter in the general TLS section has no impact on the cluster listener. Signed-off-by: Jason Yellick <[email protected]> (cherry picked from commit 5d07186)
|
Command
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description
The existing orderer code allows for a TLS timeshift to be specified
when starting the orderer with a separate cluster port. This is useful
for situations where the consenter TLS certificates have accidentally
expired, preventing quorum from forming, and preventing channel config
updates to replace these certificates.
This change extends the concept to the general orderer port, which can
be optionally re-used, rather than binding to a new port. If the
cluster port is not re-used, then the TLS timeshift parameter specified
in the general TLS section takes precdence over the parameter specified
in the cluster section. Likewise, if there is a separate cluster port,
the parameter in the general TLS section has no impact on the cluster
listener.