FAB-18204 Ch.Part.API: decouple multichannel and etcdraft #1862
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The etcdraft package imports the multichannel package. This prevents the multichannel package from using the onboarding and cluster packages, which depend on etcdraft. Here etcdraft is decoupled from multichannel by declaring an interface that capture the dependecy on the Registrar. This also eliminates some of the opaque function pointers to the Registrar that the etcdraft package was using. Signed-off-by: Yoav Tock <[email protected]> Change-Id: If8112edd7a8fe08a151bb3ca19bf0eeeedc2fb31
jyellick
approved these changes
Sep 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The etcdraft package imports the multichannel package.
This prevents the multichannel package from using the onboarding
and cluster packages, which depend on etcdraft.
Here etcdraft is decoupled from multichannel by declaring an
interface that capture the dependecy on the Registrar.
This also eliminates some of the opaque function pointers to the
Registrar that the etcdraft package was using.
Signed-off-by: Yoav Tock [email protected]
Change-Id: If8112edd7a8fe08a151bb3ca19bf0eeeedc2fb31
Type of change
Description
Refactoring to remove dependency.
Related issues
Task: FAB-18204
Epic: FAB-17712