Fix data race in gossip/discovery test #1865
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change set fixes two data races: 1) A logger reference was overriden while the logger might be in use. I changed the implementation so that the logger will be injected. 2) A shared number was incremented by logger hooks that are instantiated multiple times for different peers. I made it so that each logger hook receives its own counter, which is no longer a counter but a map of log entries that are searched. Change-Id: Ic69f604f30a16e1a1fb9050ba9145dfa38e05146 Signed-off-by: yacovm <[email protected]>
C0rWin
approved these changes
Sep 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change set fixes two data races:
A logger reference was overriden while the logger might be in use.
I changed the implementation so that the logger will be injected.
A shared number was incremented by logger hooks that are instantiated
multiple times for different peers.
I made it so that each logger hook receives its own counter, which is
no longer a counter but a map of log entries that are searched.
Change-Id: Ic69f604f30a16e1a1fb9050ba9145dfa38e05146
Signed-off-by: yacovm [email protected]