[FAB-18237] always update stateInfo message upon chaincode update #1915
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the change of FAB-18208, gossip saves CPU cycles by only updating metadata information if peer membership is not empty. However, this makes discovery incapable of operating in case anchor/bootstrap peers are not defined, or, in case the peer is the only peer in the network. This change makes gossip always update its information, including signing the stateInfo message, whenever it receives a chaincode update. Change-Id: Iaf04441944a3fe5d889233d35bdcb1173c31e2bc Signed-off-by: yacovm <[email protected]>
C0rWin
approved these changes
Sep 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the change of FAB-18208, gossip saves CPU cycles by only updating
metadata information if peer membership is not empty.
However, this makes discovery incapable of operating in case
anchor/bootstrap peers are not defined, or, in case
the peer is the only peer in the network.
This change makes gossip always update its information, including
signing the stateInfo message, whenever it receives a chaincode update.
Change-Id: Iaf04441944a3fe5d889233d35bdcb1173c31e2bc
Signed-off-by: yacovm [email protected]