Added RetrieveBlockByNumber into blockledger #2635
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
as per @manish-sethi input #2594 (comment) created a new PR for main. |
manish-sethi
reviewed
Jun 3, 2021
| @@ -93,6 +94,7 @@ func (fl *FileLedger) Iterator(startPosition *ab.SeekPosition) (blockledger.Iter | |||
|
|
|||
| iterator, err := fl.blockStore.RetrieveBlocks(startingBlockNumber) | |||
| if err != nil { | |||
| logger.Warnf("Failed to initialize block iterator from blockNum = [%d] with error = (%v)", startingBlockNumber, err) | |||
There was a problem hiding this comment.
We have been preferring to use the following function for logging
Suggested change
| logger.Warnf("Failed to initialize block iterator from blockNum = [%d] with error = (%v)", startingBlockNumber, err) | |
| logger.Warnw("Failed to initialize block iterator", "blockNum", startingBlockNumber, "error", err) |
Comment on lines
1802
to
1804
| assert.Panics(t, func() { | ||
| ConfigBlockOrPanic(l) | ||
| }) |
There was a problem hiding this comment.
- better to use
requireinstead ofassert - Wherever possible better to use
PanicsWithValueso you could test for the exact error message expected
GetBlock is used for retrieving a block in ConfigBlockOrPanic which has overhead of Iterator. It is now simplified by exposing a BlockStore function RetrieveBlockByNumber. Signed-off-by: Parameswaran Selvam <[email protected]>
manish-sethi
approved these changes
Jun 7, 2021
Param-S
added a commit
to Param-S/fabric
that referenced
this pull request
Jun 7, 2021
GetBlock is used for retrieving a block in ConfigBlockOrPanic which has overhead of Iterator. It is now simplified by exposing a BlockStore function RetrieveBlockByNumber. Signed-off-by: Parameswaran Selvam <[email protected]>
manish-sethi
pushed a commit
that referenced
this pull request
Jun 7, 2021
…2648) * FAB-18276 Ch.Part.API: extractSystemChannel must skip empty ledger (#2023) - orderer/common/server/main.go extractSystemChannel() panics when it hits an empty ledger. - In addition this method is not covered with unit tests at all. - Remove some dead code. Signed-off-by: Yoav Tock <[email protected]> Change-Id: Ie13156784d2ec600e3f97d34f20f6836b28f7662 * Added RetrieveBlockByNumber into blockledger (#2635) GetBlock is used for retrieving a block in ConfigBlockOrPanic which has overhead of Iterator. It is now simplified by exposing a BlockStore function RetrieveBlockByNumber. Signed-off-by: Parameswaran Selvam <[email protected]> Co-authored-by: Yoav Tock <[email protected]>
|
@Mergifyio backport release-2.3 |
|
Command
|
mergify bot
pushed a commit
that referenced
this pull request
Jun 8, 2021
GetBlock is used for retrieving a block in ConfigBlockOrPanic which has overhead of Iterator. It is now simplified by exposing a BlockStore function RetrieveBlockByNumber. Signed-off-by: Parameswaran Selvam <[email protected]> (cherry picked from commit 85ae90c)
manish-sethi
pushed a commit
that referenced
this pull request
Jun 8, 2021
GetBlock is used for retrieving a block in ConfigBlockOrPanic which has overhead of Iterator. It is now simplified by exposing a BlockStore function RetrieveBlockByNumber. Signed-off-by: Parameswaran Selvam <[email protected]> (cherry picked from commit 85ae90c) Co-authored-by: Parameswaran Selvam <[email protected]>
C0rWin
pushed a commit
to C0rWin/fabric
that referenced
this pull request
Sep 24, 2022
…rledger#2657) GetBlock is used for retrieving a block in ConfigBlockOrPanic which has overhead of Iterator. It is now simplified by exposing a BlockStore function RetrieveBlockByNumber. Signed-off-by: Parameswaran Selvam <[email protected]> (cherry picked from commit 85ae90c) Co-authored-by: Parameswaran Selvam <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
GetBlock is used for retrieving a block in ConfigBlockOrPanic
which has overhead of Iterator. It is now simplified by exposing
a BlockStore function RetrieveBlockByNumber.
Signed-off-by: Parameswaran Selvam [email protected]
Type of change