Show what do not match

[gqqnbig]

Signed-off-by: gqqnbig [email protected]

Type of change

• Improvement (improvement to code, performance, etc)

Description

When peer chaincode invoke submits a request, if chaincode has bugs, it may return different responses on different nodes.

Before, the error message is like

Error: could not assemble transaction: ProposalResponsePayloads do not match - proposal response: version:1 response:<status:200 payload:"true" > payload:"\n \265\277\020\265\226D\035\361\001n\371K\013\274\021F\227\002?\261\204\370\327\363r\347\010\221\313\214\031\230\022\213\001\no\0227\n\n_lifecycle\022)\n'..." endorsement:<endorser:"\n\007Org2MSP\022\252\006-----BEGIN CERTIFICATE-----\nMIICKDCCAc+gA..." signature:"0D\002 J\\300\307~\350\236\026\245H\003\337\2732\020\312\n\017Fa\306~\367x\356\347K\225..." >

That is it. Developers have no idea what mismatch what.

Now, with this PR, the error message is like

Error: could not assemble transaction: ProposalResponsePayloads do not match with version:1 response:<status:200 payload:"true" > payload:"\n \265\277\020\265\226D\035\361\001n\371K\013\274\021F\227\002?\261\204\370\327\363r\347\010\221\313\214\031\230\022\230\001\n|\0227\n\n_lifecycle\022)\n'\n..." endorsement:<endorser:"\n\007Org1MSP\022\252\006-----BEGIN CERTIFICATE-----\nMIICKDCCAc6gAwIBAgIQEO..." signature:"0E\002!\000\331p\034A\353t\261{\026#\177\211\371g\232\213\331\323..." >
- proposal response: version:1 response:<status:200 payload:"true" > payload:"\n \265\277\020\265\226D\035\361\001n\371K\013\274\021F\227\002?\261\204\370\327\363r\347\010\221\313\214\031\230\022\213\001\no\0227\n\n_lifecycle\022)\n'..." endorsement:<endorser:"\n\007Org2MSP\022\252\006-----BEGIN CERTIFICATE-----\nMIICKDCCAc+gA..." signature:"0D\002 J\\300\307~\350\236\026\245H\003\337\2732\020\312\n\017Fa\306~\367x\356\347K\225..." >

With this error message, developers can use text comparison tools to find out where the two responses start to differ, and they may get some cues.

Technically, only the payload part needs to be displayed, but I don't know how to format bytes as the toString method of ProposalResponse does.

[gqqnbig]

Let me know if you like the idea.

I know unit tests are failing. If the change is ok, I will spend more time on fixing the tests.

[gqqnbig]

@yacovm I've revised to print base64.

[gqqnbig]

@yacovm I find TestWithStaticDeliverClientLeader failed. Can you help with that?

[yacovm]

--- FAIL: TestEndorse (0.10s)
    --- FAIL: TestEndorse/non-matching_responses (0.00s)
        api_test.go:1768: 
            	Error Trace:	api_test.go:1768
            	            				api_test.go:833
            	Error:      	Error message not equal:
            	            	expected: "rpc error: code = Aborted desc = failed to assemble transaction: ProposalResponsePayloads do not match (base64):"
            	            	actual  : "rpc error: code = Aborted desc = failed to assemble transaction: ProposalResponsePayloads do not match (base64): 'EhQaEgjIARoNbW9ja19yZXNwb25zZQ==' vs 'EhkaFwjIARoSZGlmZmVyZW50X3Jlc3BvbnNl'"