Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to Gateway doc topic #3047

Merged
merged 1 commit into from
Nov 16, 2021

Conversation

denyeart
Copy link
Contributor

Update to Fabric Gateway doc topic.

Signed-off-by: David Enyeart [email protected]

Update to Fabric Gateway doc topic.

Signed-off-by: David Enyeart <[email protected]>
@denyeart denyeart requested review from a team as code owners November 16, 2021 04:28
@andrew-coleman andrew-coleman merged commit 91d7b7c into hyperledger:main Nov 16, 2021
@joshhus
Copy link
Contributor

joshhus commented Nov 16, 2021

@denyeart I thought there was a concept of a single Fabric Gateway peer that now manages Tx proposals and endorsements coming in to the network. Your edits seem to indicate that is not the case, and instead there are many "gateway" peers running the Fabric Gateway service - one per organization perhaps? Suggest clarifying that in your update.

@joshhus
Copy link
Contributor

joshhus commented Nov 16, 2021

@denyeart Suggest you take another shot at this part, you have several tangential points that are not part of this main point and create somewhat of a run on - that endorsements come from peers in various orgs, that the service runs within a peer, and we could say they do more than gather endorsements right.
Requirements previously placed on the client SDKs, such as gathering transaction endorsements from peers of various organizations, are delegated to the Fabric Gateway service running within a peer ...
So try something like -
Requirements previously placed on the client SDKs, such as managing the transaction endorsement process, are delegated to the Fabric Gateway service running on [which peer(s)?] ... (at the end state which peer(s), rather than "a" peer, since it seems important to mention where the service runs) ... `

@joshhus joshhus mentioned this pull request Nov 16, 2021
15 tasks
@denyeart
Copy link
Contributor Author

denyeart commented Nov 16, 2021

@joshhus a user can decide to enable gateway on a subset of peers, but I think it will be most common to simply have gateway enabled on all the peers. The client then decides which gateway peer to transact with. Different clients can pick different gateway peers. And in some cases the gateway peer endpoint will actually be a cluster of gateway peers that are load balanced, so the client may not even know which gateway they are communicating with currently.

Since it is already merged, please go ahead and do a pull request with any changes that you suggest, but note that Josh Kneubuhl intends to add some wording about the concept of a load balanced endpoint.

@denyeart denyeart deleted the gateway_doc_finalize branch November 16, 2021 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants