Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FAB-17136] Fix the typo error #318

Merged
merged 2 commits into from
Nov 27, 2019
Merged

[FAB-17136] Fix the typo error #318

merged 2 commits into from
Nov 27, 2019

Conversation

bjzhang03
Copy link
Contributor

This is fix #FAB-17136

When I read the resource code, I found some typo error, and I want to solve it.

Signed-off-by: bjzhang [email protected]

Type of change

  • Documentation update

Description

Fix some spelling error

Additional details

Related issues

https://jira.hyperledger.org/browse/FAB-17136

This is fix #FAB-17136

Signed-off-by: bjzhang <[email protected]>
@bjzhang03
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Commenter does not have sufficient privileges for PR 318 in repo hyperledger/fabric

@ryjones
Copy link
Contributor

ryjones commented Nov 26, 2019

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

ale-linux
ale-linux previously approved these changes Nov 26, 2019
Copy link
Contributor

@ale-linux ale-linux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fixed two small nits

@ryjones
Copy link
Contributor

ryjones commented Nov 26, 2019

DCO on both commits needs fixed

Copy link
Contributor

@guoger guoger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/azp-run

i don't exactly understand the review process here... if a maintainer added a new commit, do we still squash?

@bjzhang03
Copy link
Contributor Author

because I fix the dco problem,make the mistake。
I am so sorry。

@guoger
Copy link
Contributor

guoger commented Nov 27, 2019

@bjzhang03 no apology needed, my comment up there wasn't about you, but a general question w.r.t review process

@mastersingh24 mastersingh24 merged commit 7f30434 into hyperledger:master Nov 27, 2019
raftAtGit pushed a commit to raftAtGit/fabric that referenced this pull request Dec 2, 2019
* [FAB-17136] Fix the typo error

This is fix #FAB-17136

Signed-off-by: bjzhang <[email protected]>
raftAtGit pushed a commit to raftAtGit/fabric that referenced this pull request Dec 2, 2019
* [FAB-17136] Fix the typo error

This is fix #FAB-17136

Signed-off-by: bjzhang <[email protected]>
Signed-off-by: Hakan Eryargi <[email protected]>
cendhu pushed a commit to cendhu/fabric that referenced this pull request Dec 11, 2019
* [FAB-17136] Fix the typo error

This is fix #FAB-17136

Signed-off-by: bjzhang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants