-
Notifications
You must be signed in to change notification settings - Fork 8.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FAB-17136] Fix the typo error #318
Conversation
This is fix #FAB-17136 Signed-off-by: bjzhang <[email protected]>
/azp run |
Commenter does not have sufficient privileges for PR 318 in repo hyperledger/fabric |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I fixed two small nits
DCO on both commits needs fixed |
Signed-off-by: bjzhang <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/azp-run
i don't exactly understand the review process here... if a maintainer added a new commit, do we still squash?
because I fix the dco problem,make the mistake。 |
@bjzhang03 no apology needed, my comment up there wasn't about you, but a general question w.r.t review process |
* [FAB-17136] Fix the typo error This is fix #FAB-17136 Signed-off-by: bjzhang <[email protected]>
* [FAB-17136] Fix the typo error This is fix #FAB-17136 Signed-off-by: bjzhang <[email protected]> Signed-off-by: Hakan Eryargi <[email protected]>
* [FAB-17136] Fix the typo error This is fix #FAB-17136 Signed-off-by: bjzhang <[email protected]>
This is fix #FAB-17136
When I read the resource code, I found some typo error, and I want to solve it.
Signed-off-by: bjzhang [email protected]
Type of change
Description
Fix some spelling error
Additional details
Related issues
https://jira.hyperledger.org/browse/FAB-17136