fix FAB-17148 defer to delete 'bccsp-sw' directory #328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: baidang201 <[email protected]>
baidang201
requested review from
ale-linux,
binhn,
C0rWin,
christo4ferris,
denyeart,
guoger,
jyellick,
kchristidis,
manish-sethi,
mastersingh24,
muralisrini,
sykesm and
yacovm
as code owners
guoger
suggested changes
Nov 29, 2019
bccsp/sw/impl_test.go
Outdated
| @@ -76,10 +80,10 @@ func TestMain(m *testing.M) { | |||
| ret := m.Run() | |||
There was a problem hiding this comment.
this could be code = m.Run()
Signed-off-by: baidang201 <[email protected]>
guoger
approved these changes
Nov 29, 2019
raftAtGit
pushed a commit
to raftAtGit/fabric
that referenced
this pull request
Dec 2, 2019
* fix FAB-17148 defer to delete 'bccsp-sw' directory Signed-off-by: baidang201 <[email protected]> * 1 set code = m.Run 2 delete not user 'code =0' at last line Signed-off-by: baidang201 <[email protected]>
raftAtGit
pushed a commit
to raftAtGit/fabric
that referenced
this pull request
Dec 2, 2019
* fix FAB-17148 defer to delete 'bccsp-sw' directory Signed-off-by: baidang201 <[email protected]> * 1 set code = m.Run 2 delete not user 'code =0' at last line Signed-off-by: baidang201 <[email protected]> Signed-off-by: Hakan Eryargi <[email protected]>
cendhu
pushed a commit
to cendhu/fabric
that referenced
this pull request
Dec 11, 2019
* fix FAB-17148 defer to delete 'bccsp-sw' directory Signed-off-by: baidang201 <[email protected]> * 1 set code = m.Run 2 delete not user 'code =0' at last line Signed-off-by: baidang201 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: baidang201 [email protected]
Type of change
Bug fix
Description
fix when unit test in bccsp\sw，we find in the /tmp folder, has a lot of file like 'bccsp-sw' and can not delete auto by test program.
Additional details
the reason is when os.exit, it do not run defer to delete 'bccsp-sw' folder.
we can put os.exit in the head of function and import another defer for os.exit.
Related issues
https://jira.hyperledger.org/browse/FAB-17148