Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

certs mgmt guide #3307

Merged
merged 19 commits into from
Apr 26, 2022
Merged

certs mgmt guide #3307

merged 19 commits into from
Apr 26, 2022

Conversation

joshhus
Copy link
Contributor

@joshhus joshhus commented Mar 28, 2022

Signed-off-by: Josh Horton [email protected]

New Certs Management Guide and table

Type of change

  • Documentation update

Description

New certs mgmt guide from certs mgmt workgroup efforts.

Additional details

Needs testing / check in browser -

  • table is complex and a number of nbsp chars used
  • a number of links used

Signed-off-by: Josh Horton <[email protected]>
@joshhus joshhus requested review from a team as code owners March 28, 2022 21:58
@joshhus joshhus mentioned this pull request Mar 30, 2022
ander-db
ander-db previously approved these changes Apr 4, 2022
Signed-off-by: Josh Horton <[email protected]>
joshhus added 8 commits April 6, 2022 09:23
Signed-off-by: Josh Horton <[email protected]>
Signed-off-by: Josh Horton <[email protected]>
Signed-off-by: Josh Horton <[email protected]>
Signed-off-by: Josh Horton <[email protected]>
Signed-off-by: Josh Horton <[email protected]>
Signed-off-by: Josh Horton <[email protected]>
Signed-off-by: Josh Horton <[email protected]>
Signed-off-by: Josh Horton <[email protected]>
@joshhus
Copy link
Contributor Author

joshhus commented Apr 7, 2022

@denyeart fyi I have dir trees tweaks to make, another commit coming.

@joshhus
Copy link
Contributor Author

joshhus commented Apr 7, 2022

@ale-linux Hello can you check that your requests are resolved so we can merge? We can iterate with another PR for more minor things.

Signed-off-by: Josh Horton <[email protected]>
joshhus added 2 commits April 8, 2022 09:53
Signed-off-by: Josh Horton <[email protected]>
Signed-off-by: Josh Horton <[email protected]>
@denyeart
Copy link
Contributor

denyeart commented Apr 8, 2022

@joshhus It looks like about half of my comments were not addressed in the last commit.

@joshhus
Copy link
Contributor Author

joshhus commented Apr 13, 2022

Checking, I may have been doing them not realizing you were still adding new ones.

@joshhus
Copy link
Contributor Author

joshhus commented Apr 21, 2022

All done and committed.

@denyeart denyeart dismissed ale-linux’s stale review April 26, 2022 14:45

comments addressed

@denyeart denyeart merged commit 85c7a5e into hyperledger:main Apr 26, 2022
@denyeart
Copy link
Contributor

@Mergifyio backport release-2.4

@denyeart
Copy link
Contributor

@Mergifyio backport release-2.3

@denyeart
Copy link
Contributor

@Mergifyio backport release-2.2

@mergify
Copy link

mergify bot commented Apr 26, 2022

backport release-2.4

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Apr 26, 2022
* certs mgmt guide

Signed-off-by: Josh Horton <[email protected]>

* PR review comments and dir trees

Signed-off-by: Josh Horton <[email protected]>

* trees and edits

Signed-off-by: Josh Horton <[email protected]>

* tree tweaks

Signed-off-by: Josh Horton <[email protected]>

* tree tweaks 2

Signed-off-by: Josh Horton <[email protected]>

* trees again

Signed-off-by: Josh Horton <[email protected]>

* trees no code

Signed-off-by: Josh Horton <[email protected]>

* try pre

Signed-off-by: Josh Horton <[email protected]>

* try pre 2

Signed-off-by: Josh Horton <[email protected]>

* try pre 3

Signed-off-by: Josh Horton <[email protected]>

* update copyright date

Signed-off-by: Josh Horton <[email protected]>

* review from joshk

Signed-off-by: Josh Horton <[email protected]>

* review from davee

Signed-off-by: Josh Horton <[email protected]>

* CA links need absolute url

Signed-off-by: Josh Horton <[email protected]>

* most of the latest from dave e

Signed-off-by: Josh Horton <[email protected]>

* final 3 updates per PR review

Signed-off-by: Josh Horton <[email protected]>

* davee latest comments

Signed-off-by: Josh Horton <[email protected]>

* final 2 comments on admin certs signing

Signed-off-by: Josh Horton <[email protected]>

* a few missing comments

Signed-off-by: Josh Horton <[email protected]>
(cherry picked from commit 85c7a5e)
mergify bot pushed a commit that referenced this pull request Apr 26, 2022
* certs mgmt guide

Signed-off-by: Josh Horton <[email protected]>

* PR review comments and dir trees

Signed-off-by: Josh Horton <[email protected]>

* trees and edits

Signed-off-by: Josh Horton <[email protected]>

* tree tweaks

Signed-off-by: Josh Horton <[email protected]>

* tree tweaks 2

Signed-off-by: Josh Horton <[email protected]>

* trees again

Signed-off-by: Josh Horton <[email protected]>

* trees no code

Signed-off-by: Josh Horton <[email protected]>

* try pre

Signed-off-by: Josh Horton <[email protected]>

* try pre 2

Signed-off-by: Josh Horton <[email protected]>

* try pre 3

Signed-off-by: Josh Horton <[email protected]>

* update copyright date

Signed-off-by: Josh Horton <[email protected]>

* review from joshk

Signed-off-by: Josh Horton <[email protected]>

* review from davee

Signed-off-by: Josh Horton <[email protected]>

* CA links need absolute url

Signed-off-by: Josh Horton <[email protected]>

* most of the latest from dave e

Signed-off-by: Josh Horton <[email protected]>

* final 3 updates per PR review

Signed-off-by: Josh Horton <[email protected]>

* davee latest comments

Signed-off-by: Josh Horton <[email protected]>

* final 2 comments on admin certs signing

Signed-off-by: Josh Horton <[email protected]>

* a few missing comments

Signed-off-by: Josh Horton <[email protected]>
(cherry picked from commit 85c7a5e)
@mergify
Copy link

mergify bot commented Apr 26, 2022

backport release-2.3

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Apr 26, 2022
* certs mgmt guide

Signed-off-by: Josh Horton <[email protected]>

* PR review comments and dir trees

Signed-off-by: Josh Horton <[email protected]>

* trees and edits

Signed-off-by: Josh Horton <[email protected]>

* tree tweaks

Signed-off-by: Josh Horton <[email protected]>

* tree tweaks 2

Signed-off-by: Josh Horton <[email protected]>

* trees again

Signed-off-by: Josh Horton <[email protected]>

* trees no code

Signed-off-by: Josh Horton <[email protected]>

* try pre

Signed-off-by: Josh Horton <[email protected]>

* try pre 2

Signed-off-by: Josh Horton <[email protected]>

* try pre 3

Signed-off-by: Josh Horton <[email protected]>

* update copyright date

Signed-off-by: Josh Horton <[email protected]>

* review from joshk

Signed-off-by: Josh Horton <[email protected]>

* review from davee

Signed-off-by: Josh Horton <[email protected]>

* CA links need absolute url

Signed-off-by: Josh Horton <[email protected]>

* most of the latest from dave e

Signed-off-by: Josh Horton <[email protected]>

* final 3 updates per PR review

Signed-off-by: Josh Horton <[email protected]>

* davee latest comments

Signed-off-by: Josh Horton <[email protected]>

* final 2 comments on admin certs signing

Signed-off-by: Josh Horton <[email protected]>

* a few missing comments

Signed-off-by: Josh Horton <[email protected]>
(cherry picked from commit 85c7a5e)

# Conflicts:
#	docs/source/ops_guide.rst
@mergify
Copy link

mergify bot commented Apr 26, 2022

backport release-2.2

✅ Backports have been created

denyeart pushed a commit that referenced this pull request Apr 26, 2022
* certs mgmt guide

Signed-off-by: Josh Horton <[email protected]>

* PR review comments and dir trees

Signed-off-by: Josh Horton <[email protected]>

* trees and edits

Signed-off-by: Josh Horton <[email protected]>

* tree tweaks

Signed-off-by: Josh Horton <[email protected]>

* tree tweaks 2

Signed-off-by: Josh Horton <[email protected]>

* trees again

Signed-off-by: Josh Horton <[email protected]>

* trees no code

Signed-off-by: Josh Horton <[email protected]>

* try pre

Signed-off-by: Josh Horton <[email protected]>

* try pre 2

Signed-off-by: Josh Horton <[email protected]>

* try pre 3

Signed-off-by: Josh Horton <[email protected]>

* update copyright date

Signed-off-by: Josh Horton <[email protected]>

* review from joshk

Signed-off-by: Josh Horton <[email protected]>

* review from davee

Signed-off-by: Josh Horton <[email protected]>

* CA links need absolute url

Signed-off-by: Josh Horton <[email protected]>

* most of the latest from dave e

Signed-off-by: Josh Horton <[email protected]>

* final 3 updates per PR review

Signed-off-by: Josh Horton <[email protected]>

* davee latest comments

Signed-off-by: Josh Horton <[email protected]>

* final 2 comments on admin certs signing

Signed-off-by: Josh Horton <[email protected]>

* a few missing comments

Signed-off-by: Josh Horton <[email protected]>
(cherry picked from commit 85c7a5e)
denyeart pushed a commit that referenced this pull request Apr 26, 2022
* certs mgmt guide

Signed-off-by: Josh Horton <[email protected]>

* PR review comments and dir trees

Signed-off-by: Josh Horton <[email protected]>

* trees and edits

Signed-off-by: Josh Horton <[email protected]>

* tree tweaks

Signed-off-by: Josh Horton <[email protected]>

* tree tweaks 2

Signed-off-by: Josh Horton <[email protected]>

* trees again

Signed-off-by: Josh Horton <[email protected]>

* trees no code

Signed-off-by: Josh Horton <[email protected]>

* try pre

Signed-off-by: Josh Horton <[email protected]>

* try pre 2

Signed-off-by: Josh Horton <[email protected]>

* try pre 3

Signed-off-by: Josh Horton <[email protected]>

* update copyright date

Signed-off-by: Josh Horton <[email protected]>

* review from joshk

Signed-off-by: Josh Horton <[email protected]>

* review from davee

Signed-off-by: Josh Horton <[email protected]>

* CA links need absolute url

Signed-off-by: Josh Horton <[email protected]>

* most of the latest from dave e

Signed-off-by: Josh Horton <[email protected]>

* final 3 updates per PR review

Signed-off-by: Josh Horton <[email protected]>

* davee latest comments

Signed-off-by: Josh Horton <[email protected]>

* final 2 comments on admin certs signing

Signed-off-by: Josh Horton <[email protected]>

* a few missing comments

Signed-off-by: Josh Horton <[email protected]>
(cherry picked from commit 85c7a5e)
denyeart pushed a commit to denyeart/fabric that referenced this pull request Apr 26, 2022
* certs mgmt guide

Signed-off-by: Josh Horton <[email protected]>

* PR review comments and dir trees

Signed-off-by: Josh Horton <[email protected]>

* trees and edits

Signed-off-by: Josh Horton <[email protected]>

* tree tweaks

Signed-off-by: Josh Horton <[email protected]>

* tree tweaks 2

Signed-off-by: Josh Horton <[email protected]>

* trees again

Signed-off-by: Josh Horton <[email protected]>

* trees no code

Signed-off-by: Josh Horton <[email protected]>

* try pre

Signed-off-by: Josh Horton <[email protected]>

* try pre 2

Signed-off-by: Josh Horton <[email protected]>

* try pre 3

Signed-off-by: Josh Horton <[email protected]>

* update copyright date

Signed-off-by: Josh Horton <[email protected]>

* review from joshk

Signed-off-by: Josh Horton <[email protected]>

* review from davee

Signed-off-by: Josh Horton <[email protected]>

* CA links need absolute url

Signed-off-by: Josh Horton <[email protected]>

* most of the latest from dave e

Signed-off-by: Josh Horton <[email protected]>

* final 3 updates per PR review

Signed-off-by: Josh Horton <[email protected]>

* davee latest comments

Signed-off-by: Josh Horton <[email protected]>

* final 2 comments on admin certs signing

Signed-off-by: Josh Horton <[email protected]>

* a few missing comments

Signed-off-by: Josh Horton <[email protected]>
denyeart pushed a commit that referenced this pull request Apr 26, 2022
* certs mgmt guide

Signed-off-by: Josh Horton <[email protected]>

* PR review comments and dir trees

Signed-off-by: Josh Horton <[email protected]>

* trees and edits

Signed-off-by: Josh Horton <[email protected]>

* tree tweaks

Signed-off-by: Josh Horton <[email protected]>

* tree tweaks 2

Signed-off-by: Josh Horton <[email protected]>

* trees again

Signed-off-by: Josh Horton <[email protected]>

* trees no code

Signed-off-by: Josh Horton <[email protected]>

* try pre

Signed-off-by: Josh Horton <[email protected]>

* try pre 2

Signed-off-by: Josh Horton <[email protected]>

* try pre 3

Signed-off-by: Josh Horton <[email protected]>

* update copyright date

Signed-off-by: Josh Horton <[email protected]>

* review from joshk

Signed-off-by: Josh Horton <[email protected]>

* review from davee

Signed-off-by: Josh Horton <[email protected]>

* CA links need absolute url

Signed-off-by: Josh Horton <[email protected]>

* most of the latest from dave e

Signed-off-by: Josh Horton <[email protected]>

* final 3 updates per PR review

Signed-off-by: Josh Horton <[email protected]>

* davee latest comments

Signed-off-by: Josh Horton <[email protected]>

* final 2 comments on admin certs signing

Signed-off-by: Josh Horton <[email protected]>

* a few missing comments

Signed-off-by: Josh Horton <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants