FAB-16437 Remove common/mocks from validator #352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- stop using common/mocks in
core/handlers/validation/builtin/v13
- stop using mock cc as it adds more complexity than
needed when you can simply "create" lscc records
Change-Id: I459eb4e0c1ec30d5374de5a5feda56a6d26948d6
Signed-off-by: Gari Singh <[email protected]>
mastersingh24
requested review from
ale-linux,
binhn,
C0rWin,
christo4ferris,
denyeart,
guoger,
jyellick,
kchristidis,
manish-sethi,
muralisrini,
sykesm and
yacovm
as code owners
- generate mocks within the package Change-Id: Idf8dcd70a59c68d323ea78880cebec22b63966fb Signed-off-by: Gari Singh <[email protected]>
mastersingh24
changed the title
denyeart
approved these changes
Dec 3, 2019
kchristidis
approved these changes
Dec 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Improvement
Description
Mocks should be generated in the package in which they are used.
This is part of removing the use of common/mocks as it is a
bad pattern.
Additional details
This removes common/mocks from core/handlers/validation.
Related issues
FAB-16437