Unfreeze active nodes metrics once a consenter is evicted #3536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ad of being frozen we set it to 0 once halt is called. Tests. Signed-off-by: Vladyslav Kopaihorodskyi <[email protected]>
kopaygorodsky
force-pushed
the
fix_metrics_active_nodes
branch
from
d880bf3 to
32f4139
Compare
|
code looks good, will re-run UTs |
yacovm
approved these changes
Jul 20, 2022
|
Do we want to backport this fix into 2.2 and 2.3? |
I don't know, doesn't seem anyone besides you noticed this :-) @denyeart do we want this backported? |
|
@Mergifyio backport release-2.5 |
mergify bot
pushed a commit
that referenced
this pull request
Jul 26, 2022
…ad of being frozen we set it to 0 once halt is called. Tests. (#3536) Signed-off-by: Vladyslav Kopaihorodskyi <[email protected]> (cherry picked from commit ba61a1b)
✅ Backports have been created
|
|
@Mergifyio backport release-2.4 |
|
@Mergifyio backport release-2.2 |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Jul 26, 2022
…ad of being frozen we set it to 0 once halt is called. Tests. (#3536) Signed-off-by: Vladyslav Kopaihorodskyi <[email protected]> (cherry picked from commit ba61a1b)
mergify bot
pushed a commit
that referenced
this pull request
Jul 26, 2022
…ad of being frozen we set it to 0 once halt is called. Tests. (#3536) Signed-off-by: Vladyslav Kopaihorodskyi <[email protected]> (cherry picked from commit ba61a1b) # Conflicts: # orderer/consensus/etcdraft/chain_test.go
✅ Backports have been created
|
|
Our policy now is to backport to in-flight releases (release-2.5), latest release (release-2.4), and latest LTS release (release-2.2) if somebody sees a need. |
denyeart
pushed a commit
that referenced
this pull request
Jul 26, 2022
…ad of being frozen we set it to 0 once halt is called. Tests. (#3536) Signed-off-by: Vladyslav Kopaihorodskyi <[email protected]> (cherry picked from commit ba61a1b)
denyeart
pushed a commit
that referenced
this pull request
Jul 26, 2022
…ad of being frozen we set it to 0 once halt is called. Tests. (#3536) Signed-off-by: Vladyslav Kopaihorodskyi <[email protected]> (cherry picked from commit ba61a1b)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed active nodes metrics for etcdraft when a node is evicted. Instead of being frozen we set it to 0 once halt is called. Tests.