Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FAB-14083] Chaincode as an external service documentation #399
[FAB-14083] Chaincode as an external service documentation #399
Changes from all commits
1432b66
2420fa5
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This still isn't correct. We are prescribing a sample implementation instead of documenting the function in fabric.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a JIRA opened to change these to be values within the document instead of spreading them around the tree. That changes the key and the semantics and keep the definitions consistent between chaincode clients (what we have today) and chaincode servers (what this is talking about).
I really don't think it will make beta so this is mostly informational...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I really think most of this unnecessarily overlaps with what we have in the other doc.
In my earlier comment I suggested the areas to focus on here; I'll go further and say that I think the connection.json should be documented or linked within the
/bin/release
portion of external builders as that's really the only intersection between the two.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're needlessly complicating examples by having these assertions. It looks like we're just copying the contents of tests.