Remove attestation server #5126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The attestation server was a concept that was abandoned during the implementation of the BFT block puller. It is now dead code. The aim of the attestation server was to pull only headers from the delivery server. It was implemented in a simpler fashion by augmenting the `seekInfo.ContentType` with `ab.SeekInfo_HEADER_WITH_SIG` which causes the desired behavior (see common/deliver/deliver.go L338). Signed-off-by: Yoav Tock <[email protected]>
|
@denyeart can you take a look? |
Sure, I was waiting to see if any of the other orderer developers were going to review, but since it is a simple removal I'm happy to approve and merge. |
denyeart
approved these changes
Feb 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description
The attestation server was a concept that was abandoned during the implementation of the BFT block puller.
It is now dead code.
The aim of the attestation server was to pull only headers from the delivery server. It was implemented in a simpler fashion by augmenting the
seekInfo.ContentTypewithab.SeekInfo_HEADER_WITH_SIGwhich causes the desired behavior (see common/deliver/deliver.go L338).