Release action - Separate runner for amd64 and arm64 #5128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously arm64 images were created on a standard amd64 runner using qemu. qemu emulation is very slow and there have been recent issues. Native image creation is faster and more reliable. This change creates separate runners for amd64 and arm64. A new job is then needed to combine the image digests into a multi-architecture manifest that gets pushed to Docker Hub and ghcr. Signed-off-by: David Enyeart <[email protected]>
denyeart
force-pushed
the
release_native_runners
branch
from
43b8987 to
8a2922a
Compare
|
@hyperledger/fabric-core-maintainers |
pfi79
approved these changes
Jan 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously arm64 images were created on a standard amd64 runner using qemu.
qemu emulation is very slow and there have been recent issues.
Native image creation is faster and more reliable.
This change creates separate runners for amd64 and arm64.
Also updates to ubuntu-22.04 since the new arm64 runners are only available for ubuntu-22.04 and ubuntu-24.04.
A new job is then needed to combine the image digests into a multi-architecture manifest that gets pushed to Docker Hub and ghcr.
This PR is against release-2.5 branch so that release v2.5.11 can be created. Upon success the change will be cherry-picked to main branch.