Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix install script for 3.0.0-preview Docker images #5151

Merged
merged 1 commit into from
Feb 21, 2025

Conversation

bestbeforetoday
Copy link
Member

The install script incorrectly selected ghcr.io as the repository to pull Fabric 3.0.0-preview Docker images.

This change removes trailing pre-release or metadata identifiers from Docker image tags before looking up the default Docker registry for a given component version. This means that 3.0.0-preview is treated the same as 3.0.0.

The install script incorrectly selected ghcr.io as the repository to
pull Fabric 3.0.0-preview Docker images.

This change removes trailing pre-release or metadata identifiers from
Docker image tags before looking up the default Docker registry for a
given component version. This means that 3.0.0-preview is treated the
same as 3.0.0.

Signed-off-by: Mark S. Lewis <[email protected]>
@bestbeforetoday bestbeforetoday marked this pull request as ready for review February 21, 2025 16:10
@bestbeforetoday bestbeforetoday requested a review from a team as a code owner February 21, 2025 16:10
@denyeart denyeart merged commit 84d7d77 into hyperledger:main Feb 21, 2025
15 checks passed
@bestbeforetoday bestbeforetoday deleted the docker-install branch February 21, 2025 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants