-
Notifications
You must be signed in to change notification settings - Fork 8.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare for go 1.14 #755
Merged
Merged
Prepare for go 1.14 #755
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- bump golang.org/x/crypto/sha3 to pick up checkptr fix - soften assertion in error string to handle quotes present in go 1.14 error that is not present in go 1.13 Change-Id: Ia046217c5ab77a5e7f5713544663be19e52e118c Signed-off-by: Matthew Sykes <[email protected]>
Thanks Matt, LGTM |
I guess 1.14 doesn't fix pre-existing flakes |
Nope. And I just hit another one (FAB-17376). |
Just wondering why is this necessary? We don't use sha3 in Fabric. |
yacovm
approved these changes
Feb 27, 2020
|
lindluni
pushed a commit
that referenced
this pull request
Nov 17, 2020
- bump golang.org/x/crypto/sha3 to pick up checkptr fix Change-Id: Ia046217c5ab77a5e7f5713544663be19e52e118c Signed-off-by: Matthew Sykes <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before we can move to go 1.14, we need to make sure things work with go 1.14...
error that is not present in go 1.13