Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementing graphql apis for label application rules #108

Merged
merged 16 commits into from
Nov 5, 2021

Conversation

kamaleshnneerasa
Copy link
Contributor

Description

Please include a summary of the change, motivation and context.

Testing

Please describe the tests that you ran to verify your changes. Please summarize what did you test and what needs to be tested e.g. deployed and tested helm chart locally.

Checklist:

  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules

Documentation

Make sure that you have documented corresponding changes in this repository or hypertrace docs repo if required.

@github-actions

This comment has been minimized.

@codecov
Copy link

codecov bot commented Oct 27, 2021

Codecov Report

Merging #108 (47be40c) into main (ed9fa50) will increase coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #108      +/-   ##
============================================
+ Coverage     22.98%   23.03%   +0.04%     
  Complexity       75       75              
============================================
  Files            65       65              
  Lines          1679     1680       +1     
  Branches         52       52              
============================================
+ Hits            386      387       +1     
  Misses         1284     1284              
  Partials          9        9              
Flag Coverage Δ
unit 23.03% <100.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ava/org/hypertrace/graphql/impl/GraphQlModule.java 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ed9fa50...47be40c. Read the comment docs.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

Copy link
Contributor

@aaron-steinfeld aaron-steinfeld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like not quite ready, but added early feedback.

@kamaleshnneerasa kamaleshnneerasa marked this pull request as ready for review October 29, 2021 12:08
@kamaleshnneerasa kamaleshnneerasa requested a review from a team as a code owner October 29, 2021 12:08
Copy link
Contributor

@aaron-steinfeld aaron-steinfeld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Conflicts also need to be resolved

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@aaron-steinfeld
Copy link
Contributor

Let's fix snyk before merging please.

@aaron-steinfeld
Copy link
Contributor

Let's fix snyk before merging please.

The vulnerability being raised is in gson, which comes in transitively. Adding a constraint to the platform similar to below should do the trick.

diff --git a/hypertrace-graphql-platform/build.gradle.kts b/hypertrace-graphql-platform/build.gradle.kts
index 0611e17..466c56e 100644
--- a/hypertrace-graphql-platform/build.gradle.kts
+++ b/hypertrace-graphql-platform/build.gradle.kts
@@ -13,5 +13,8 @@ dependencies {
     api("org.hypertrace.config.service:spaces-config-service-api:0.1.1")
     api("org.hypertrace.config.service:labels-config-service-api:0.1.8")
     api("org.hypertrace.config.service:label-application-rule-config-service-api:0.1.14")
+    api("com.google.code.gson:gson:2.8.9") {
+      because("https://snyk.io/vuln/SNYK-JAVA-COMGOOGLECODEGSON-1730327")
+    }
   }
 }
\ No newline at end of file

@kamaleshnneerasa kamaleshnneerasa merged commit 597ad5f into main Nov 5, 2021
@kamaleshnneerasa kamaleshnneerasa deleted the label_application_rules_gql branch November 5, 2021 05:50
@github-actions
Copy link

github-actions bot commented Nov 5, 2021

Unit Test Results

11 files  ±0  11 suites  ±0   15s ⏱️ -3s
24 tests ±0  24 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 597ad5f. ± Comparison against base commit ed9fa50.

skjindal93 pushed a commit that referenced this pull request Jun 21, 2024
* refactor: update jackson

* fix: data packages require version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants