-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implementing graphql apis for label application rules #108
Conversation
This comment has been minimized.
This comment has been minimized.
Codecov Report
@@ Coverage Diff @@
## main #108 +/- ##
============================================
+ Coverage 22.98% 23.03% +0.04%
Complexity 75 75
============================================
Files 65 65
Lines 1679 1680 +1
Branches 52 52
============================================
+ Hits 386 387 +1
Misses 1284 1284
Partials 9 9
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks like not quite ready, but added early feedback.
...org/hypertrace/graphql/label/application/rules/dao/LabelApplicationRuleConfigServiceDao.java
Outdated
Show resolved
Hide resolved
...org/hypertrace/graphql/label/application/rules/dao/LabelApplicationRuleConfigServiceDao.java
Outdated
Show resolved
Hide resolved
...n/java/org/hypertrace/graphql/label/application/rules/dao/LabelApplicationRuleDaoModule.java
Show resolved
Hide resolved
...org/hypertrace/graphql/label/application/rules/dao/LabelApplicationRuleRequestConverter.java
Outdated
Show resolved
Hide resolved
...g/hypertrace/graphql/label/application/rules/request/LabelApplicationRuleRequestBuilder.java
Show resolved
Hide resolved
...rg/hypertrace/graphql/label/application/rules/request/LabelApplicationRuleUpdateRequest.java
Outdated
Show resolved
Hide resolved
...g/hypertrace/graphql/label/application/rules/schema/mutation/CreateLabelApplicationRule.java
Outdated
Show resolved
Hide resolved
...in/java/org/hypertrace/graphql/label/application/rules/schema/shared/CompositeCondition.java
Outdated
Show resolved
Hide resolved
...in/java/org/hypertrace/graphql/label/application/rules/schema/shared/CompositeCondition.java
Outdated
Show resolved
Hide resolved
...org/hypertrace/graphql/label/application/rules/dao/LabelApplicationRuleRequestConverter.java
Show resolved
Hide resolved
...chema/src/main/java/org/hypertrace/graphql/label/application/rules/schema/shared/Action.java
Outdated
Show resolved
Hide resolved
...org/hypertrace/graphql/label/application/rules/dao/LabelApplicationRuleRequestConverter.java
Outdated
Show resolved
Hide resolved
...org/hypertrace/graphql/label/application/rules/dao/LabelApplicationRuleRequestConverter.java
Outdated
Show resolved
Hide resolved
...org/hypertrace/graphql/label/application/rules/dao/LabelApplicationRuleRequestConverter.java
Outdated
Show resolved
Hide resolved
...org/hypertrace/graphql/label/application/rules/dao/LabelApplicationRuleRequestConverter.java
Show resolved
Hide resolved
...rg/hypertrace/graphql/label/application/rules/dao/LabelApplicationRuleResponseConverter.java
Outdated
Show resolved
Hide resolved
...chema/src/main/java/org/hypertrace/graphql/label/application/rules/schema/shared/Action.java
Outdated
Show resolved
Hide resolved
.../java/org/hypertrace/graphql/label/application/rules/schema/shared/LabelApplicationRule.java
Outdated
Show resolved
Hide resolved
.../java/org/hypertrace/graphql/label/application/rules/schema/shared/LabelApplicationRule.java
Show resolved
Hide resolved
...src/main/java/org/hypertrace/graphql/label/application/rules/schema/shared/StaticLabels.java
Show resolved
Hide resolved
...g/hypertrace/graphql/label/application/rules/request/LabelApplicationRuleRequestBuilder.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Conflicts also need to be resolved
...chema/src/main/java/org/hypertrace/graphql/label/application/rules/schema/shared/Action.java
Outdated
Show resolved
Hide resolved
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Let's fix snyk before merging please. |
The vulnerability being raised is in gson, which comes in transitively. Adding a constraint to the platform similar to below should do the trick. diff --git a/hypertrace-graphql-platform/build.gradle.kts b/hypertrace-graphql-platform/build.gradle.kts
index 0611e17..466c56e 100644
--- a/hypertrace-graphql-platform/build.gradle.kts
+++ b/hypertrace-graphql-platform/build.gradle.kts
@@ -13,5 +13,8 @@ dependencies {
api("org.hypertrace.config.service:spaces-config-service-api:0.1.1")
api("org.hypertrace.config.service:labels-config-service-api:0.1.8")
api("org.hypertrace.config.service:label-application-rule-config-service-api:0.1.14")
+ api("com.google.code.gson:gson:2.8.9") {
+ because("https://snyk.io/vuln/SNYK-JAVA-COMGOOGLECODEGSON-1730327")
+ }
}
}
\ No newline at end of file
|
* refactor: update jackson * fix: data packages require version
Description
Please include a summary of the change, motivation and context.
Testing
Please describe the tests that you ran to verify your changes. Please summarize what did you test and what needs to be tested e.g. deployed and tested helm chart locally.
Checklist:
Documentation
Make sure that you have documented corresponding changes in this repository or hypertrace docs repo if required.