Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use container provided channel registry #153

Merged
merged 2 commits into from
Aug 2, 2022

Conversation

aaron-steinfeld
Copy link
Contributor

Description

Consume refactor to use the container's channel registry rather than building our own internally
Depends on hypertrace/hypertrace-core-graphql#106

@github-actions
Copy link

github-actions bot commented Aug 2, 2022

Test Results

24 tests   24 ✔️  13s ⏱️
11 suites    0 💤
11 files      0

Results for commit 9f1eed2.

♻️ This comment has been updated with latest results.

@codecov
Copy link

codecov bot commented Aug 2, 2022

Codecov Report

Merging #153 (9f1eed2) into main (3b65dfb) will increase coverage by 0.03%.
The diff coverage is 60.00%.

@@             Coverage Diff              @@
##               main     #153      +/-   ##
============================================
+ Coverage     22.77%   22.80%   +0.03%     
  Complexity       75       75              
============================================
  Files            65       65              
  Lines          1739     1741       +2     
  Branches         53       53              
============================================
+ Hits            396      397       +1     
- Misses         1334     1335       +1     
  Partials          9        9              
Flag Coverage Δ
unit 22.80% <60.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...va/org/hypertrace/graphql/impl/GraphQlFactory.java 0.00% <0.00%> (ø)
...ava/org/hypertrace/graphql/impl/GraphQlModule.java 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@aaron-steinfeld aaron-steinfeld marked this pull request as ready for review August 2, 2022 20:59
@aaron-steinfeld aaron-steinfeld requested a review from a team as a code owner August 2, 2022 20:59
@aaron-steinfeld aaron-steinfeld merged commit d30509b into main Aug 2, 2022
@aaron-steinfeld aaron-steinfeld deleted the external-grpc-registry branch August 2, 2022 20:59
skjindal93 pushed a commit that referenced this pull request Jun 21, 2024
* fix: add support for deserializing zoned expressions

* chore: suppression update
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants