Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(api): expose highest_precedence_dtype() #10868

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat(api): expose highest_precedence_dtype() #10868

wants to merge 2 commits into from

Conversation

NickCrews
Copy link
Contributor

Fixes #9335

@NickCrews NickCrews changed the title Publish-highest_precedence_dtype feat(api): expose highest_precedence_dtype() Feb 20, 2025
@github-actions github-actions bot added the tests Issues or PRs related to tests label Feb 20, 2025
@github-actions GitHub Actions
Copy link
Contributor

ACTION NEEDED

Ibis follows the Conventional Commits specification for release automation.

The PR title and description are used as the merge commit message.

Please update your PR title and description to match the specification.

@NickCrews NickCrews force-pushed the publish-highest_precedence_dtype branch from d405407 to 7559b3d Compare February 20, 2025 02:32
@NickCrews NickCrews force-pushed the publish-highest_precedence_dtype branch from 7559b3d to d7666dc Compare February 20, 2025 04:21
@github-actions github-actions bot added the datatypes Issues relating to ibis's datatypes (under `ibis.expr.datatypes`) label Feb 20, 2025
@NickCrews
Copy link
Contributor Author

quarto is having a hard time finding the function:

quartodoc.builder.utils.WorkaroundKeyError: Cannot find an object named: highest_precedence. Does an object with the path ibis:highest_precedence_dtype exist?

Any idea how to fix this? It seems to be contradicting itself, looking for both highest_precedence and highest_precedence_dtype?

cpcloud
cpcloud reviewed Feb 20, 2025
View reviewed changes
ibis/expr/datatypes/cast.py

Returns
-------
The highest precedence datatype.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The highest precedence datatype.
DataType
The highest precedence datatype.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpcloud cpcloud cpcloud left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
datatypes Issues relating to ibis's datatypes (under `ibis.expr.datatypes`) tests Issues or PRs related to tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: expose highest_precedence(*dtypes)
2 participants
@NickCrews @cpcloud