Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore/destroy kuber dash #1344

Merged
merged 6 commits into from
Apr 27, 2017
Merged

Chore/destroy kuber dash #1344

merged 6 commits into from
Apr 27, 2017

Conversation

121watts
Copy link
Contributor

@121watts 121watts commented Apr 27, 2017

  • CHANGELOG.md updated
  • Rebased/mergable
  • Tests pass
  • Sign CLA (if not already signed)

Connect #1242

Notes

Also adds empty state to dashboards index.

@cryptoquick cryptoquick self-requested a review April 27, 2017 20:09
Copy link
Contributor

@cryptoquick cryptoquick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yappp the link is deleted from both the dashboard, and the router. Good cleanup!

@@ -57,10 +52,10 @@ const DashboardsPage = React.createClass({
let tableHeader
if (dashboards === null) {
tableHeader = 'Loading Dashboards...'
} else if (dashboards.length === 0) {
} else if (dashboards.length === 1) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@121watts 121watts merged commit cf6652d into master Apr 27, 2017
@121watts 121watts deleted the chore/destroy-kuber-dash branch April 27, 2017 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants